Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Alpine JDK8 build #221

Merged
merged 2 commits into from
Mar 10, 2022
Merged

add Alpine JDK8 build #221

merged 2 commits into from
Mar 10, 2022

Conversation

gdams
Copy link
Member

@gdams gdams commented Dec 12, 2021

Keep as draft until adoptium/jdk8u#4 has landed

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

karianna
karianna approved these changes Dec 12, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams gdams marked this pull request as ready for review January 14, 2022 09:18
@gdams
Copy link
Member Author

gdams commented Jan 14, 2022

run tests

@gdams gdams closed this Jan 14, 2022
@gdams gdams reopened this Jan 14, 2022
@gdams gdams marked this pull request as draft January 14, 2022 09:39
@gdams gdams marked this pull request as draft January 14, 2022 09:39
@adoptium adoptium deleted a comment from eclipse-temurin-bot Mar 9, 2022
@gdams
Copy link
Member Author

gdams commented Mar 10, 2022

run tests

@gdams gdams marked this pull request as ready for review March 10, 2022 14:56
karianna
karianna approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Member Author

gdams commented Mar 10, 2022

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

sxa
sxa approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa sxa mentioned this pull request Mar 10, 2022
Closed
@gdams gdams merged commit 73fc6e0 into adoptium:master Mar 10, 2022
@gdams gdams deleted the alpine8 branch March 10, 2022 19:41
@sxa sxa mentioned this pull request Apr 9, 2022
Closed
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request May 10, 2024
@AdamBrousseau
Merge pull request adoptium#221 from mahdipub/enable_ebc
e29a355 
enables sanity.perf in x64 linux for EBC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
jenkins-pipeline testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gdams @eclipse-temurin-bot @karianna @sxa