Verify Windows and Mac Signing signatures in all executables and installers #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
|
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
Digging into the pipeline failures - looks like Mac Os X signing failures e.g., Error: executable is 'adhoc' Signed: unpacked/jdk/expanded_java.management.jmod/lib/libmanagement.dylib |
karianna
previously requested changes
Nov 29, 2023
There was a problem hiding this comment.
Error: executable is 'adhoc' Signed: unpacked/jdk/expanded_java.management.jmod/lib/libmanagement.dylib
FAILURE: The following 194 executables are not signed correctly:
unpacked/jre/jdk-21.0.1+12-jre/Contents/Home/bin/jwebserver
unpacked/jre/jdk-21.0.1+12-jre/Contents/Home/bin/jfr
unpacked/jre/jdk-21.0.1+12-jre/Contents/Home/bin/rmiregistry
@karianna So yeah, the pr-tester does not Eclipse "Sign" the dylibs, so it's actually accurate, but we obviously don't want the pr-tester to fail! So I shall have to exclude the sign_verification from the pr-tester. |
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
|
run tests |
andrew-m-leonard
dismissed
karianna’s stale review
Added check to not verify pr-tester as it does not sign binaries
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
run tests |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
|
@karianna checks look all good now |
luhenry
pushed a commit
to luhenry/adoptium-ci-jenkins-pipelines
that referenced
this pull request
Feb 3, 2024
…allers (adoptium#848) * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Signing verifier job Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Don't verify pr-tester binaries as they are not signed Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adoptium/temurin-build#3494
For Temurin builds, verify that for Windows and Mac platforms all the following are correctly signed with a non-adhoc Signature: