Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Windows and Mac Signing signatures in all executables and installers #848

Merged
merged 92 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
089f565
Signing verifier job
andrew-m-leonard Nov 22, 2023
8607168
Signing verifier job
andrew-m-leonard Nov 22, 2023
85b0eda
Signing verifier job
andrew-m-leonard Nov 22, 2023
cfac822
Signing verifier job
andrew-m-leonard Nov 22, 2023
dff906f
Signing verifier job
andrew-m-leonard Nov 22, 2023
364239d
Signing verifier job
andrew-m-leonard Nov 22, 2023
b77f9bf
Signing verifier job
andrew-m-leonard Nov 22, 2023
ae27273
Signing verifier job
andrew-m-leonard Nov 22, 2023
b785ea3
Signing verifier job
andrew-m-leonard Nov 22, 2023
3355152
Signing verifier job
andrew-m-leonard Nov 22, 2023
df270aa
Signing verifier job
andrew-m-leonard Nov 22, 2023
5584177
Signing verifier job
andrew-m-leonard Nov 22, 2023
ee442cb
Signing verifier job
andrew-m-leonard Nov 22, 2023
e88d623
Signing verifier job
andrew-m-leonard Nov 22, 2023
431e73d
Signing verifier job
andrew-m-leonard Nov 22, 2023
4c38281
Signing verifier job
andrew-m-leonard Nov 22, 2023
2588dd4
Signing verifier job
andrew-m-leonard Nov 22, 2023
a243ea4
Signing verifier job
andrew-m-leonard Nov 22, 2023
2de20dc
Signing verifier job
andrew-m-leonard Nov 22, 2023
a955b0a
Signing verifier job
andrew-m-leonard Nov 22, 2023
c4d9723
Signing verifier job
andrew-m-leonard Nov 22, 2023
20d1395
Signing verifier job
andrew-m-leonard Nov 22, 2023
4555bbc
Signing verifier job
andrew-m-leonard Nov 22, 2023
9196e15
Signing verifier job
andrew-m-leonard Nov 23, 2023
4e1c969
Signing verifier job
andrew-m-leonard Nov 23, 2023
66bca21
Signing verifier job
andrew-m-leonard Nov 23, 2023
3aadbfd
Signing verifier job
andrew-m-leonard Nov 23, 2023
ea6ae8c
Signing verifier job
andrew-m-leonard Nov 23, 2023
e0d0d27
Signing verifier job
andrew-m-leonard Nov 23, 2023
f7e7077
Signing verifier job
andrew-m-leonard Nov 23, 2023
cfb8658
Signing verifier job
andrew-m-leonard Nov 23, 2023
5165f3f
Signing verifier job
andrew-m-leonard Nov 23, 2023
e528f64
Signing verifier job
andrew-m-leonard Nov 23, 2023
eeb4036
Signing verifier job
andrew-m-leonard Nov 23, 2023
94592b7
Signing verifier job
andrew-m-leonard Nov 23, 2023
afc4c29
Signing verifier job
andrew-m-leonard Nov 24, 2023
fbf88a7
Signing verifier job
andrew-m-leonard Nov 24, 2023
b165a2d
Signing verifier job
andrew-m-leonard Nov 27, 2023
d3eba8e
Signing verifier job
andrew-m-leonard Nov 27, 2023
0a43dd8
Signing verifier job
andrew-m-leonard Nov 27, 2023
faf9274
Signing verifier job
andrew-m-leonard Nov 27, 2023
b38add9
Signing verifier job
andrew-m-leonard Nov 27, 2023
e8dfcf4
Signing verifier job
andrew-m-leonard Nov 27, 2023
f9c838b
Signing verifier job
andrew-m-leonard Nov 27, 2023
1f7a20e
Signing verifier job
andrew-m-leonard Nov 27, 2023
8650152
Signing verifier job
andrew-m-leonard Nov 27, 2023
8dc6079
Signing verifier job
andrew-m-leonard Nov 27, 2023
7afd732
Signing verifier job
andrew-m-leonard Nov 27, 2023
195ec08
Signing verifier job
andrew-m-leonard Nov 27, 2023
6d3efb5
Signing verifier job
andrew-m-leonard Nov 28, 2023
0f851e0
Signing verifier job
andrew-m-leonard Nov 28, 2023
74979f5
Signing verifier job
andrew-m-leonard Nov 28, 2023
d3aaaf7
Signing verifier job
andrew-m-leonard Nov 28, 2023
53b0939
Signing verifier job
andrew-m-leonard Nov 28, 2023
66d4028
Signing verifier job
andrew-m-leonard Nov 28, 2023
27c9d08
Signing verifier job
andrew-m-leonard Nov 28, 2023
c0e14ce
Signing verifier job
andrew-m-leonard Nov 28, 2023
35e4b4d
Signing verifier job
andrew-m-leonard Nov 28, 2023
a190efc
Signing verifier job
andrew-m-leonard Nov 28, 2023
4a62e1d
Signing verifier job
andrew-m-leonard Nov 28, 2023
17d30f0
Signing verifier job
andrew-m-leonard Nov 29, 2023
6b6fa1e
Signing verifier job
andrew-m-leonard Nov 29, 2023
a13702e
Signing verifier job
andrew-m-leonard Nov 29, 2023
49a7324
Signing verifier job
andrew-m-leonard Nov 29, 2023
aa7379e
Signing verifier job
andrew-m-leonard Nov 29, 2023
aafe206
Signing verifier job
andrew-m-leonard Nov 29, 2023
1f3e18f
Signing verifier job
andrew-m-leonard Nov 29, 2023
efbb935
Signing verifier job
andrew-m-leonard Nov 29, 2023
0c4bafc
Signing verifier job
andrew-m-leonard Nov 29, 2023
5c473aa
Signing verifier job
andrew-m-leonard Nov 29, 2023
17e4f96
Signing verifier job
andrew-m-leonard Nov 29, 2023
2cad46b
Signing verifier job
andrew-m-leonard Nov 29, 2023
5a2a758
Signing verifier job
andrew-m-leonard Nov 29, 2023
00fcb1c
Signing verifier job
andrew-m-leonard Nov 29, 2023
1a42d94
Signing verifier job
andrew-m-leonard Nov 29, 2023
841e6ac
Signing verifier job
andrew-m-leonard Nov 29, 2023
ca574bd
Signing verifier job
andrew-m-leonard Nov 29, 2023
4161fe9
Signing verifier job
andrew-m-leonard Nov 29, 2023
6a8c60e
Signing verifier job
andrew-m-leonard Nov 29, 2023
6ec6cc5
Signing verifier job
andrew-m-leonard Nov 29, 2023
6b8f4d2
Signing verifier job
andrew-m-leonard Nov 29, 2023
13fb79c
Signing verifier job
andrew-m-leonard Nov 29, 2023
5607b6f
Signing verifier job
andrew-m-leonard Nov 29, 2023
1f1d74b
Signing verifier job
andrew-m-leonard Nov 29, 2023
a4963e8
Signing verifier job
andrew-m-leonard Nov 29, 2023
3ffea58
Signing verifier job
andrew-m-leonard Nov 29, 2023
268018e
Signing verifier job
andrew-m-leonard Nov 29, 2023
d81a3d8
Signing verifier job
andrew-m-leonard Nov 29, 2023
5d5db03
Signing verifier job
andrew-m-leonard Nov 29, 2023
c118ab9
Signing verifier job
andrew-m-leonard Nov 29, 2023
70cfd26
Signing verifier job
andrew-m-leonard Nov 29, 2023
d1ca460
Don't verify pr-tester binaries as they are not signed
andrew-m-leonard Nov 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions pipelines/build/common/openjdk_build_pipeline.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,42 @@ class Build {
flatten: true)
}

// For Windows and Mac verify that all necessary executables are Signed and Notarized(mac)
private void verifySigning() {
if (buildConfig.TARGET_OS == "windows" || buildConfig.TARGET_OS == "mac") {
try {
context.println "RUNNING sign_verification for ${buildConfig.TARGET_OS}/${buildConfig.ARCHITECTURE} ..."

// Determine suitable node to run on
def verifyNode
if (buildConfig.TARGET_OS == "windows") {
verifyNode = "ci.role.test&&sw.os.windows"
} else {
verifyNode = "ci.role.test&&(sw.os.osx||sw.os.mac)"
}
if (buildConfig.ARCHITECTURE == "aarch64") {
verifyNode = verifyNode + "&&hw.arch.aarch64"
} else {
verifyNode = verifyNode + "&&hw.arch.x86"
}

// Execute sign verification job
context.build job: 'build-scripts/release/sign_verification',
propagate: true,
parameters: [
context.string(name: 'UPSTREAM_JOB_NUMBER', value: "${env.BUILD_NUMBER}"),
context.string(name: 'UPSTREAM_JOB_NAME', value: "${env.JOB_NAME}"),
context.string(name: 'TARGET_OS', value: "${buildConfig.TARGET_OS}"),
context.string(name: 'TARGET_ARCH', value: "${buildConfig.ARCHITECTURE}"),
context.string(name: 'NODE_LABEL', value: "${verifyNode}")
]
} catch (e) {
context.println("Failed to sign_verification for ${buildConfig.TARGET_OS}/${buildConfig.ARCHITECTURE} ${e}")
currentBuild.result = 'FAILURE'
}
}
}

private void gpgSign() {
context.stage('GPG sign') {
context.println "RUNNING sign_temurin_gpg for ${buildConfig.TARGET_OS}/${buildConfig.ARCHITECTURE} ..."
Expand Down Expand Up @@ -2052,6 +2088,17 @@ class Build {
}
}

if (!env.JOB_NAME.contains('pr-tester')) { // pr-tester does not sign the binaries
// Verify Windows and Mac Signing for Temurin
if (buildConfig.VARIANT == 'temurin') {
try {
verifySigning()
} catch (Exception e) {
context.println(e.message)
}
}
}

// Compare reproducible build if needed
if (enableReproducibleCompare) {
compareReproducibleBuild(nonDockerNodeName)
Expand Down
Loading