Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: add new dockerstatic container for Redhat UBI8 #2532 #2557

Merged
merged 5 commits into from
May 24, 2022

Conversation

steelhead31
Copy link
Contributor

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@sxa
Copy link
Member

sxa commented May 17, 2022

@steelhead31 Ref what Haroon said earlier, did you manage to get this Dockerfile to work without tripping up on Xvfb/epel?

@steelhead31
Copy link
Contributor Author

steelhead31 commented May 18, 2022

@steelhead31 Ref what Haroon said earlier, did you manage to get this Dockerfile to work without tripping up on Xvfb/epel?

Yes, I've just checked my local container from my development, and this command works... yum -y install xorg-x11-server-Xvfb

however I did notice doing a yum install in the container appears to pick up my locally configured repos...

Let me do a little more testing, by removing my local repos, and recreating the container.

@sxa
Copy link
Member

sxa commented May 18, 2022

@steelhead31 Hmmm doesn't seem to work for me as it fails to install epel and then fails to install Xvfb:

[sxa@fedora ~]$ podman run -it redhat/ubi8
[root@af73f82a04f4 /]# dnf -y update && dnf install -y perl openssh-server unzip wget epel-release
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Red Hat Universal Base Image 8 (RPMs) - BaseOS                                  1.8 MB/s | 781 kB     00:00    
Red Hat Universal Base Image 8 (RPMs) - AppStream                               6.5 MB/s | 2.9 MB     00:00    
Red Hat Universal Base Image 8 (RPMs) - CodeReady Builder                        71 kB/s |  17 kB     00:00    
Dependencies resolved.
Nothing to do.
Complete!
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Last metadata expiration check: 0:00:01 ago on Wed May 18 09:10:41 2022.
No match for argument: epel-release
Error: Unable to find a match: epel-release
[root@af73f82a04f4 /]# dnf install xorg-x11-server-Xvfb 
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Last metadata expiration check: 0:00:44 ago on Wed May 18 09:10:41 2022.
No match for argument: xorg-x11-server-Xvfb
Error: Unable to find a match: xorg-x11-server-Xvfb
[root@af73f82a04f4 /]# 

@steelhead31
Copy link
Contributor Author

steelhead31 commented May 18, 2022

@steelhead31 Ref what Haroon said earlier, did you manage to get this Dockerfile to work without tripping up on Xvfb/epel?

Tried it again, it definitely works ok.. built an image from the dockerfile, ran a container up, and XVFB is installed..

[root@e00edf570dcb /]# yum -y install xorg-x11-server-Xvfb
Updating Subscription Management repositories.
Unable to read consumer identity
Subscription Manager is operating in container mode.
Red Hat Enterprise Linux 8 for x86_64 - BaseOS (RPMs) 5.2 kB/s | 2.4 kB 00:00
RHEL 8 CSB 4.7 kB/s | 2.1 kB 00:00
Extra Packages for Enterprise Linux Modular 8 - x86_64 5.5 kB/s | 2.5 kB 00:00
Extra Packages for Enterprise Linux 8 - x86_64 6.4 kB/s | 2.8 kB 00:00
Red Hat Enterprise Linux 8 for x86_64 - AppStream (RPMs) 6.7 kB/s | 2.8 kB 00:00
Package xorg-x11-server-Xvfb-1.20.11-2.el8.x86_64 is already installed.
Dependencies resolved.
Nothing to do.

@sxa its still picking up my CSB laptops repos... I'll tweak the dockerfile to either add the repos, or more likely do a manual install via wget .. would you mind testing the new dockerfile? , before I commit the changes again.

@sxa
Copy link
Member

sxa commented May 18, 2022

Yeah I'll try and fit it in before my meeting-a-thon this afternoon :-)

Updated the URL for api adoptium.net, and added additional repos to provide package dependencies.
@github-actions github-actions bot added docker and removed docker labels May 18, 2022
@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented May 18, 2022

@steelhead31 Hmmm doesn't seem to work for me as it fails to install epel and then fails to install Xvfb:

@sxa The fix is in my requested changes. The x11 packages installs fine after installing the centos 8 stream repo that way

Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the changes in the latest commit, the container builds just fine.

I've create a new jenkins node for it here https://ci.adoptopenjdk.net/computer/test-docker-ubi8-x64-1/. Running a sanity test here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4642/console

Merge after the grinder runs to completion

@Haroon-Khel
Copy link
Contributor

java/lang/ProcessHandle/InfoTest.java.InfoTest failed, but this may be specific to ubi8. I'm happy to merge this since the container is up and running, and any test failures can be investigated in a separate issue. @karianna still needs an approve from you I think

@sxa
Copy link
Member

sxa commented May 19, 2022

java/lang/ProcessHandle/InfoTest.java.InfoTest failed, but this may be specific to ubi8. I'm happy to merge this since the container is up and running, and any test failures can be investigated in a separate issue. @karianna still needs an approve from you I think

That failure should be looked into if it's repeatable on this machine and not others - can you get any more info our of the test other that it threw an exception?

@sxa
Copy link
Member

sxa commented May 19, 2022

Fixes #2532

@steelhead31
Copy link
Contributor Author

java/lang/ProcessHandle/InfoTest.java.InfoTest failed, but this may be specific to ubi8. I'm happy to merge this since the container is up and running, and any test failures can be investigated in a separate issue. @karianna still needs an approve from you I think

That failure should be looked into if it's repeatable on this machine and not others - can you get any more info our of the test other that it threw an exception?

@sxa / @Haroon-Khel .. it appears this may be a known issue.. whilst doing some investigating I came across this...
clearlinux/distribution#1142 , do you think the same is occuring here ?

@sxa
Copy link
Member

sxa commented May 23, 2022

java/lang/ProcessHandle/InfoTest.java.InfoTest failed, but this may be specific to ubi8. I'm happy to merge this since the container is up and running, and any test failures can be investigated in a separate issue. @karianna still needs an approve from you I think

That failure should be looked into if it's repeatable on this machine and not others - can you get any more info our of the test other that it threw an exception?

@sxa / @Haroon-Khel .. it appears this may be a known issue.. whilst doing some investigating I came across this... clearlinux/distribution#1142 , do you think the same is occuring here ?

Hmmm I don't think UBI should be running tools like sleep through busybox which appears to be what that issue is talking about.

@steelhead31
Copy link
Contributor Author

java/lang/ProcessHandle/InfoTest.java.InfoTest failed, but this may be specific to ubi8. I'm happy to merge this since the container is up and running, and any test failures can be investigated in a separate issue. @karianna still needs an approve from you I think

That failure should be looked into if it's repeatable on this machine and not others - can you get any more info our of the test other that it threw an exception?

@sxa / @Haroon-Khel .. it appears this may be a known issue.. whilst doing some investigating I came across this... clearlinux/distribution#1142 , do you think the same is occuring here ?

Hmmm I don't think UBI should be running tools like sleep through busybox which appears to be what that issue is talking about.

Yes, I was thinking more the coreutils, but if not the same root cause, possibly a similar symptom, in that the spawned process doesnt have the expected ID.

@sxa
Copy link
Member

sxa commented May 23, 2022

Hmmm yes fairly reproducible outside java on UBI:

[root@ab0fb5a43bba /]# sleep 100 &
[1] 28
[root@ab0fb5a43bba /]# ps -ef | grep $!
root          28       1  0 16:51 pts/0    00:00:00 /usr/bin/coreutils --coreutils-prog-shebang=sleep /usr/bin/sleep 100
root          30       1  0 16:51 pts/0    00:00:00 grep --color=auto 28
[root@ab0fb5a43bba /]#  cat /usr/bin/sleep 
#!/usr/bin/coreutils --coreutils-prog-shebang=sleep
[root@ab0fb5a43bba /]#

@steelhead31
Copy link
Contributor Author

steelhead31 commented May 23, 2022

Hmmm yes fairly reproducible outside java on UBI:

[root@ab0fb5a43bba /]# sleep 100 &
[1] 28
[root@ab0fb5a43bba /]# ps -ef | grep $!
root          28       1  0 16:51 pts/0    00:00:00 /usr/bin/coreutils --coreutils-prog-shebang=sleep /usr/bin/sleep 100
root          30       1  0 16:51 pts/0    00:00:00 grep --color=auto 28
[root@ab0fb5a43bba /]#  cat /usr/bin/sleep 
#!/usr/bin/coreutils --coreutils-prog-shebang=sleep
[root@ab0fb5a43bba /]#

#sxa Replacing the ubi9 coreutils-single with the regular coreutils, makes the sleep command behave normally in its subprocess, can I get access to the dockerhost/container to test a fix... basically I want to run this command on the container

yum install -y coreutils --allowerasing

and then retry the grinder tests, alternatively @Haroon-Khel , would you mind doing this ?.. if this does work, its a minor change to the dockerfile.

@sxa
Copy link
Member

sxa commented May 23, 2022

PMd you with the info you need to reproduce ;-)

@steelhead31
Copy link
Contributor Author

This latest commit fixes the LANG_0 & LANG_1 test failures.. here in grinder.. https://ci.adoptopenjdk.net/job/Grinder/4785/console

@github-actions github-actions bot removed the docker label May 24, 2022
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@sxa sxa merged commit f6b9344 into adoptium:master May 24, 2022
@steelhead31 steelhead31 deleted the fix_issue_2532 branch May 24, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants