-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Include check for ntpd service. #3455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you redo the commit message to prefix it with unixPB:
(Can be done on squash but if someone else does it it's likely to get missed.
Do we install the ntp packages in containers? Assuming yes I guess it just doesn't get registered which is why this fails?
13794e6
to
8212474
Compare
Done, we do install NTPD, but the docker containers lack "services" , systemctl returns a bus error, which I guess is a docker thing, so I think this is probably the closes thing to a solution. It seems to work OK on Centos7 & Centos8, but the VPC on Centos6 failed, so I'll need to do a bit more investigation into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systemctl returns a bus error
Yikes, but ok ... :-)
For documentation purposes... systemd requires CAP_SYS_ADMIN capability but Docker drops that capability in the non privileged containers, in order to add more security... I guess we could look to implement this if required in our containers. |
51df03e
to
1f78d15
Compare
Rerun Of The VPC with improved handling for CentOS6.. |
262f40d
to
2727e9e
Compare
I wouldn't have thought we need it. Is hope that time sync would be handled by the host for the containerised environment |
Failing checks are known issues and not related. |
UnixPB: Improve NTPD Checks
124e25c
to
4667fc3
Compare
Fixes #3454
Checklist
VPC Completed OK: https://ci.adoptium.net/job/VagrantPlaybookCheck/1842/