Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPB: Include check for ntpd service. #3455

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Mar 6, 2024

Fixes #3454

Checklist

VPC Completed OK: https://ci.adoptium.net/job/VagrantPlaybookCheck/1842/

@steelhead31 steelhead31 marked this pull request as ready for review March 6, 2024 17:17
@steelhead31 steelhead31 requested a review from sxa March 6, 2024 17:34
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you redo the commit message to prefix it with unixPB: (Can be done on squash but if someone else does it it's likely to get missed.

Do we install the ntp packages in containers? Assuming yes I guess it just doesn't get registered which is why this fails?

@steelhead31
Copy link
Contributor Author

Can you redo the commit message to prefix it with unixPB: (Can be done on squash but if someone else does it it's likely to get missed.

Do we install the ntp packages in containers? Assuming yes I guess it just doesn't get registered which is why this fails?

Done, we do install NTPD, but the docker containers lack "services" , systemctl returns a bus error, which I guess is a docker thing, so I think this is probably the closes thing to a solution. It seems to work OK on Centos7 & Centos8, but the VPC on Centos6 failed, so I'll need to do a bit more investigation into that.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

systemctl returns a bus error

Yikes, but ok ... :-)

@steelhead31
Copy link
Contributor Author

systemctl returns a bus error

Yikes, but ok ... :-)

For documentation purposes...

systemd requires CAP_SYS_ADMIN capability but Docker drops that capability in the non privileged containers, in order to add more security... I guess we could look to implement this if required in our containers.

@steelhead31
Copy link
Contributor Author

Rerun Of The VPC with improved handling for CentOS6..

https://ci.adoptium.net/job/VagrantPlaybookCheck/1840/

@steelhead31 steelhead31 marked this pull request as ready for review March 6, 2024 20:35
@steelhead31 steelhead31 marked this pull request as draft March 6, 2024 20:40
@steelhead31 steelhead31 force-pushed the fix_ntpd_start branch 2 times, most recently from 262f40d to 2727e9e Compare March 6, 2024 21:17
@steelhead31 steelhead31 marked this pull request as ready for review March 6, 2024 21:33
@sxa
Copy link
Member

sxa commented Mar 6, 2024

systemd requires CAP_SYS_ADMIN capability ...I guess we could look to implement this if required in our containers.

I wouldn't have thought we need it. Is hope that time sync would be handled by the host for the containerised environment

@steelhead31
Copy link
Contributor Author

Failing checks are known issues and not related.

UnixPB: Improve NTPD Checks
@steelhead31 steelhead31 merged commit 79d44e2 into adoptium:master Mar 7, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centos 7 docker image update job failing
3 participants