-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Installer option for JavaSoft registry entries missing #300
Comments
Sorry I don't see it missing but for some language the translation item name and desc seems not to work anymore. Translation KO :
What language are you using ? Can you share a screenshot ? |
@douph1 My Windows system is using German, hence it should be de-de. The installer dialog shows the following options on my system: Edit: The strange part is that the same installer on a different German Windows 10 system shows the |
I found the reason for this defect: I have also installed AdoptOpenJDK 15 JDK for experiments. If the installer detects this value then the option This behavior does not make any sense to me. The JavaSoft registry values exist so that it is possible to detect all installed Java versions and select the best matching JDK/JRE. Therefore the JavaSoft option should be selectable no matter what other JREs/JDKs are already installed. |
see https://github.com/AdoptOpenJDK/openjdk-installer/blob/master/wix/Main.hotspot.wxs.template
Oracle :
If we allow you to override CurrentVersion from JDK 15 with value from JDK11 we will not respect this. |
@douph1 The option
These are the values that really matters because they can be used to find an installed JDK. If the CurrentVersion entry is found you can just skip it but please allow the installer to write the other entries. |
Are you suggesting to have two installer options ?
How two handle backward compat ? |
That is not necessary. But if you want to mimic the Oracle behavior you can always show the JavaSoft option and if it is selected but That would the the obvious logical way to handle such a situation in my opinion. But please do never hide the JavaSoft installer option. |
Seems it was fix by #307. Feel free to reopen if needed |
The latest version AdoptOpenJDK 11 version
OpenJDK11U-jdk_x64_windows_hotspot_11.0.10_9.msi
misses the option to create the JavaSoft registry entries.Those entries are required by a lot of programs to find an existing JRE/JDK installation (e.g. Lauch4j).
The text was updated successfully, but these errors were encountered: