Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Main.wxs.template #842

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Main.wxs.template #842

wants to merge 3 commits into from

Commits on Mar 16, 2024

  1. Update Main.wxs.template 

    Removed the JavaSoftCurrentVersion component condition.

Temurin 8 JavaSoftCurrentVersion key is not removed at uninstall, because the condition is never satisfied. For Temurin 11, 17, etc, the condition doesn't make any sense because it's comparing with version "1.8", but Temurin 8 has totally different keys.

Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
    @adipiciu
    adipiciu committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    a9e428c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into adipiciu-patch-4

    @karianna
    karianna committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    dda5b68 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'master' into adipiciu-patch-4

    @karianna
    karianna committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    353f894 View commit details
    Browse the repository at this point in the history