Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch Windows JDK11 builds to use VS2019 #2992

Merged
merged 3 commits into from Jun 22, 2022
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Jun 21, 2022

The Visual Studio 2019 backport is now complete for JDK11 which means we should be able to start building using VS2019

@karianna
Copy link
Contributor

LGTM

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (subject to the tests that you're working on)

@gdams gdams merged commit 98b7e13 into adoptium:master Jun 22, 2022
@gdams gdams deleted the vs2019 branch June 22, 2022 14:06
pshipton added a commit to pshipton/openjdk-build that referenced this pull request Aug 26, 2022
Issue eclipse-openj9/openj9#15582
See also adoptium#2992

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9 that referenced this pull request Aug 26, 2022
Issue eclipse-openj9#15582
See also
adoptium/temurin-build#2992
ibmruntimes/temurin-build#25

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Issues that affect or relate to the WINDOWS OS
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants