New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: switch Windows JDK11 builds to use VS2019 #2992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
windows
Issues that affect or relate to the WINDOWS OS
label
Jun 21, 2022
LGTM |
karianna
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
sxa
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (subject to the tests that you're working on)
This was referenced Aug 26, 2022
pshipton
added a commit
to pshipton/openjdk-build
that referenced
this pull request
Aug 26, 2022
Issue eclipse-openj9/openj9#15582 See also adoptium#2992 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Aug 26, 2022
Issue eclipse-openj9#15582 See also adoptium/temurin-build#2992 ibmruntimes/temurin-build#25 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Studio 2019 backport is now complete for JDK11 which means we should be able to start building using VS2019