Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch jdk8 Windows compilation to use VS2019 #15051

Closed
pshipton opened this issue May 12, 2022 · 8 comments
Closed

Switch jdk8 Windows compilation to use VS2019 #15051

pshipton opened this issue May 12, 2022 · 8 comments
Labels
comp:build doc:externals
Milestone
Release 0.38 (Jav...

Comments

@pshipton
Copy link
Member

We need to keep an eye on this. There may be a switch to Windows compilation coming.

See adoptium/temurin-build#2922
and 8221988: add possibility to build with Visual Studio 2019
@pshipton
Copy link
Member Author

pshipton commented May 19, 2022 •
edited
Loading

The change is promoted in jdk8u342-b02.
8221988: add possibility to build with Visual Studio 2019

@pshipton
Copy link
Member Author

I tried a build with VS2019 but it failed

13:39:08  C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
13:39:08  C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
13:39:08  C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
13:39:08  C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
13:39:08  C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
13:39:08  C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2873: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': symbol cannot be used in a using-declaration
13:39:08  make[2]: *** [lib/Awt2dLibraries.gmk:466: /cygdrive/f/Users/jenkins/workspace/Build_JDK8_x86-64_windows_Personal/build/windows-x86_64-normal-server-release/jdk/objs/libawt/awt_DCHolder.obj] Error 2
``

@pshipton
Copy link
Member Author

pshipton commented May 31, 2022 •
edited
Loading

I'm trying a build with VS2017.
https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/169/

  • sanity/extended functional & system, sanity.openjdk

@pshipton
Copy link
Member Author

The VS2017 build all passed.

AdamBrousseau added a commit to AdamBrousseau/openjdk-build that referenced this issue May 31, 2022
@AdamBrousseau
Bump to VS2017 for jdk8 Windows compiles
ff81bb8 
Also remove duplicate entry for freetype version

Related eclipse-openj9/openj9#15051

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau mentioned this issue May 31, 2022
Merged
AdamBrousseau added a commit to AdamBrousseau/openjdk-build that referenced this issue May 31, 2022
@AdamBrousseau
Bump to VS2017 for jdk8 Windows compiles
31d2caa 
Also remove duplicate entry for freetype version

Related eclipse-openj9/openj9#15051

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@pshipton pshipton mentioned this issue Jun 6, 2022
Merged
@pshipton
Copy link
Member Author

pshipton commented Jun 7, 2022

Builds are switched to VS2017. Move this forward to consider VS2019 later.

@AdamBrousseau
Copy link
Contributor

FYI Adopt moved jdk11 to VS2019. Maybe we need to cover that in a different issue
adoptium/temurin-build#2992

@pshipton
Copy link
Member Author

I don't know there is any urgency to switch, we can target after 0.33

@pshipton pshipton mentioned this issue Jul 20, 2022
Closed
pshipton added a commit to pshipton/openj9 that referenced this issue Feb 10, 2023
@pshipton
Build jdk8 Windows with VS 2019
e23ae5f 
Issue eclipse-openj9#15051

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This was referenced Feb 10, 2023
Merged
Merged
@pshipton
Copy link
Member Author

0.38 M1 used VS2019 without issue.

Doc issue eclipse-openj9/openj9-docs#1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build doc:externals
Projects
None yet
Milestone
Release 0.38 (Java 8, 11, 17) Apr ref...
Development

No branches or pull requests
3 participants
@AdamBrousseau @tajila @pshipton