Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrowave OPL3 express #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Retrowave OPL3 express #26

wants to merge 3 commits into from

Conversation

mywave82
Copy link
Contributor

Addresses adplug/adplug#164

@mywave82
Copy link
Contributor Author

mywave82 commented Jun 27, 2023 •
edited

  • Split out the two initial patches to separate PRs
  • Add a OPL3 reset on program exit to avoid hanging notes
  • Reset does not function as expecting, can leave hanging notes, seems to be in bank1 or OPL2 vs OPL3 mode.
  • Test on Mingw / Windows
  • Test on MacOS

@mywave82
Copy link
Contributor Author

@ClassicOldSong @ReimuNotMoe

@mywave82
* Setting Baud-Rate appears to not be needed, and does not compile co…
73f9ee8 
…rrectly an multiple systems

* Reset by pin did not work due to firmware bug when only sending one byte of data, but it makes a clicking sound so we prefer to just set the OPL3 into a known state
* OS X have bug in the USB serial buffering, so we must send smaller chunks at a time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mywave82