Support disk type conversion #102
Conversation
- support backword compatibility about box disk format. use create_vol_xml_from() to convert disk format automatically instead of create_vol_xml() and upload Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
FYI: http://libvirt.org/html/libvirt-libvirt.html#virStorageVolCreateXMLFrom Since libvirt 1.0.1, we can get higher performance with qcow2, with specifying flag, but need Fedora19, and Debian Jessie. That's because I don't add the flag here. |
|
This modification cause box directory such as ~/.vagrant.d/boxes/lucid/kvm become root.root owner. |
- add permission block to XML Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
Fix the permission issue. |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
I'm not sure I understand the change. Are you creating a storage pool for each VM? What's the point. This also blocks a change I'm working on to let the storage pool be defined by a parameter. |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
Upload code in vagrant-libvit don't support qcow2/raw conversion. virStorageVolCreateXMLFrom in libvirt support qcow2/raw conversion. To use virStorageVolCreateXMLFrom, I add box directory as storage pool in temporary. |
|
OK, I understand better now, makes sense. |
|
I have a regression with your code from commit 5bd991d#diff-8fbdf238b2fce9e29b19e7ba2100083c where you give ownership of the pool to the user. This doesn't work for me, it sets ownership to UID/GUID -1/-1, also I think the owner is supposed to be root with libvirt giving ownership to qemu when needed. Does it work for you? Is it a Debian/Fedora difference issue? We need to work on adding test to prevent issues like this in the future. |
|
in ubuntu/debian, gid/uid returns user's one. It seems be a different behavior. |
7c399e1 by @adrahon breaks disk image type conversion.
This pull request fix it with libvirt API.
TBD: progress information when conversion.