Windows-friendly handler file names #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriaan-pelzer
approved these changes
Sep 14, 2018
deconstruct.js
Outdated
| const pathParameterFlag = ':'; | ||
|
|
||
| if (typeof options === 'object') { | ||
| routeDir = options.routeDir; |
There was a problem hiding this comment.
Would you handle the case where options.routeDir is undefined? Throwing is ok for now, I think.
There was a problem hiding this comment.
Another thing: Will this actually work? Will JS allow you to change the value of a const?
There was a problem hiding this comment.
how about:
const routeDir = (typeof options === 'string') ? (options || 'routes') : (options.routeDir || 'routes');
There was a problem hiding this comment.
Another thing: Will this actually work? Will JS allow you to change the value of a const?
I got so used to rely on eslint/typescript in other projects that I didn't even notice until that errored at runtime :)
|
Closes #1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #1
Also renamed
routetorouteFileNameto make it clear it does not refer to the routes in express, and added some doc