Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added search bar functionality for products page #119

Merged
merged 2 commits into from May 23, 2017
Merged

Conversation

elis47
Copy link
Collaborator

@elis47 elis47 commented May 22, 2017

This change is Reviewable

@adrianharabula
Copy link
Owner

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


.gitignore, line 5 at r1 (raw file):

app/config/algolia\.php

app/config/scout\.php

o să vedem aici cum facem cu fişierele de configurare. Trebuie pe cât posibil să evităm punerea datelor de autentificare pe git, dar în acelaşi timp fişierele astea ar trebui să fie pe git


app/app/Http/Controllers/GroupsController.php, line 28 at r1 (raw file):

  function search(Request $request) {
    $name = $request->group_name;
    $groups = Group::search($name)->get();

uite ce frumos arată searchul :)


app/resources/views/addpreferences.blade.php, line 24 at r1 (raw file):

                <div class="checkbox">
                  <label>
                    <input name="wanted" type="checkbox" value="">I want the following characteristics

ce legătură are asta cu modificările pentru search?


Comments from Reviewable

Copy link
Owner

@adrianharabula adrianharabula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge 👍

@adrianharabula adrianharabula merged commit a5b5a60 into master May 23, 2017
@adrianharabula adrianharabula deleted the work_elis branch May 23, 2017 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants