-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Refactor #13
Major Refactor #13
Conversation
1 similar comment
parser.go
Outdated
return p.err | ||
} | ||
|
||
// SetErr assigns the an error. Calling this method has no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogdanprodanj I doubt this is going to get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icholy thank you very much for the time you took to improve the library. I really like your changes, specially, the way you have simplified and unified the parsing process. But before merging it, I would like to ask you the following:
- provide a
parser_test.go
to cover the newparser.go
generic parser helper. - provide coverage for the new lines introduced in
sentence.go
andtypes.go
. Exact lines here and here marked as "NEW". - fix the golint offenses. It's not breaking the tests because we need to add the new
-set_exit_status
flag to thegolint
command in.travis.yml
. Can you add that too? :) - fix the typo mentioned by @bogdanprodanj
Thanks again. I really appreciate your work.
@adrianmo I didn't notice your message till right now. I'll update the pr asap. |
Great @icholy :) |
@adrianmo ready for review, bumped your coverage by 10% ;). I skipped the test for |
@icholy thank you for making the changes. I'm merging this PR now. |
This is a pretty big refactor that introduce breaking changes. Let me know what you think.
Breaking changes
Date
&Time
types.float64
orint64
.Sentence
toSent
Sent.GetSentence()
toSent.Sentence()
SentenceI
toMessage
NewLatLong
toParseLatLong
Non-Breaking changes
ParseSentence(string)
Sent.Prefix() string
nmea:
prefix to error messages.parser
to simplify sentence parsing.