Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null values in GPRMC speed & course fields #9

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Allow null values in GPRMC speed & course fields #9

merged 3 commits into from
Jun 19, 2017

Conversation

icholy
Copy link
Collaborator

@icholy icholy commented Jun 19, 2017

Fixes #8

@coveralls
Copy link

coveralls commented Jun 19, 2017 •
edited

Coverage Status

Coverage increased (+0.05%) to 86.77% when pulling 93029b9 on icholy:master into adc20ca on adrianmo:master.

@adrianmo
Copy link
Owner

@icholy thanks for the PR. Can you add a couple of test cases for GPRMC with sentences missing speed and course?

@icholy
Copy link
Collaborator Author

icholy commented Jun 19, 2017

@adrianmo done.

@coveralls
Copy link

coveralls commented Jun 19, 2017 •
edited

Coverage Status

Coverage increased (+0.05%) to 86.77% when pulling 17059e5 on icholy:master into adc20ca on adrianmo:master.

@adrianmo
Copy link
Owner

Thanks @icholy

@adrianmo adrianmo merged commit 86d6f6d into adrianmo:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmo adrianmo adrianmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icholy @coveralls @adrianmo