Support for setting PlantUML Server URL #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `plantumlServerUrl` defaulting to `https://www.plantuml.com/plantuml` so that a private PlantUML server can be configured. Also enables configuring the image format, defaulting to `svg`.
|
Are you still accepting PRs on this repo? |
|
Hi, yes. I intend to handle this repo this weekend, there's a huge todo list waiting. I was way too busy for way too long at work and never managed to focus on the uncommited changes I did before. Also, https://github.com/plantuml-stdlib/C4-PlantUML happened, and tried to use my spare time there. Sorry for not responding earlier. Happy holidays 🎄 |
|
No problem. No rush! I was just putting together some docs on how to use it for an internal project and wanted to note where it should be installed from. We’re using the features in this PR. Thanks for your work! |
This was referenced Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
plantumlServerUrldefaulting tohttps://www.plantuml.com/plantumlsothat a private PlantUML server can be configured.
Also enables configuring the image format, defaulting to
svg.