Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable flake8-blind-except in ruff #641

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 99.822%. remained the same
when pulling 59029c1 on DimitriPapadopoulos:flake8-blind-except
into 0d7ae7b on adrienverge:master.

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 for this one.
Changing these would satisfy a linter, but YamllintConfig.extend() can raise something else than an AssertionError (moreover we may change in the future). With except Exception as e, any present or future problem will continue to be caught.

@DimitriPapadopoulos
Copy link
Contributor Author

Agreed. The idea is that you must know and document the exceptions raised by a piece code. While this might nice be in simple cases and deep in function call trees, it is not always feasible higher in a function call tree, especially when like here you do want to catch any exception.

@DimitriPapadopoulos DimitriPapadopoulos deleted the flake8-blind-except branch January 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants