Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for new violation issue-#1081 #11

Closed
fwald opened this issue Feb 23, 2020 · 0 comments
Closed

Add documentation for new violation issue-#1081 #11

fwald opened this issue Feb 23, 2020 · 0 comments
Assignees

Comments

@fwald
Copy link
Collaborator

fwald commented Feb 23, 2020

Add the necessary documentation for the new violation

@fwald fwald self-assigned this Feb 23, 2020
fwald added a commit that referenced this issue Feb 23, 2020
…edViolation (WPS357). Follows the general structure for documentation.

Relates to original issue wemake-services#1081. Closes #11
Mema5 pushed a commit that referenced this issue Feb 23, 2020
Mema5 pushed a commit that referenced this issue Feb 25, 2020
…edViolation (WPS357). Follows the general structure for documentation.

Relates to original issue wemake-services#1081. Closes #11
@Mema5 Mema5 closed this as completed Feb 25, 2020
sobolevn added a commit that referenced this issue Oct 22, 2020
…s#1178)

* feat: added the new violation to be completed, closes #7

* refac: refactor for flake8 consistancy, issue #7

* feat: implementing the new rule. Build yet to be debugged. Issue #9

* test: added a test for violation WPS357. A raw string must contain the '\' character. If there is no '\' in the string a raw string should not be used.
Closes issue #8
Relates to issue#1081 on the original repository

* documentation: Added documentation for the violation RawStringNotNeededViolation (WPS357). Follows the general structure for documentation.
Relates to original issue wemake-services#1081. Closes #11

* fix: Removed an unnecessary single quotation mark in the documentation
relates to #11

* fix: repaired build a priori, issue #9

* fix: adapted test suite to respect the new rule. Temporarily removed some cases to make the test pass. Related to issue #9

* fix: corrected the WPS warnings, issue #9

* fix: enforce the new rule WPS357 in the project itself

* refac: old tests to match the new rule or ignore it, issue #9

* refac: last refactoring. Closes #9

* doc: changelogs for new rule

* test: added a test for wrong case. PR wemake-services#1178

* fix: minor changes required for PR wemake-services#1187

* Doc:
* CHANGELOG.md: new header for release 0.15.0
* added contribution
* Related to PR wemake-services#1178

* test: new tests for rule WPS357. Not passing for escaped quote. PR wemake-services#1178

* fix: correct type and missing newline. PR wemake-services#1178

* tests: refactored tests that now all pass. Closes #9. Related to PR wemake-services#1178

* doc: the previous usage was actually a wrong usage. PR wemake-services#1178

* refac: remove useless encode().decode()

* merged and solve the conflits. All tests pass

* fix: minor changes for PR wemake-services#1178

* fix: error linter wrong indentation, related to PR wemake-services#1178

* fix: wrong error_template in for RawStringNotNeededViolation

* Fixes Ci

* Fixes Ci

Co-authored-by: Mael MADON <mael.madon@polytechnique.edu>
Co-authored-by: fabian.waldner@gmail.com <fabian.waldner@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants