Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-#1081 implement the rule #9

Closed
Mema5 opened this issue Feb 23, 2020 · 0 comments
Closed

issue-#1081 implement the rule #9

Mema5 opened this issue Feb 23, 2020 · 0 comments
Assignees
@Mema5

Comments

@Mema5
Copy link
Collaborator

Mema5 commented Feb 23, 2020

One can use both r'abc' and 'abc' to represent a simple string.
But, r strings are only required when dealing with \ in your strings.
So, the rule is: if there's no \ in your string, then do not use r
@Mema5 Mema5 self-assigned this Feb 23, 2020
Mema5 pushed a commit that referenced this issue Feb 23, 2020
feat: implementing the new rule. Build yet to be debugged. Issue #9
ba02e8a
Mema5 pushed a commit that referenced this issue Feb 23, 2020
fix: repaired build a priori, issue #9
e7aae53
Mema5 pushed a commit that referenced this issue Feb 23, 2020
fix: adapted test suite to respect the new rule. Temporarily removed …
ddf0c3a 
…some cases to make the test pass. Related to issue #9
Mema5 pushed a commit that referenced this issue Feb 23, 2020
fix: corrected the WPS warnings, issue #9
e9bc6e7
Mema5 pushed a commit that referenced this issue Feb 23, 2020
refac: old tests to match the new rule or ignore it, issue #9
ebca79d
Mema5 pushed a commit that referenced this issue Feb 23, 2020
refac: last refactoring. Closes #9
abcc8bf
Mema5 added a commit that referenced this issue Feb 24, 2020
@Mema5
tests: refactored tests that now all pass. Closes #9. Related to PR w…
5961039 
…emake-services#1178
Mema5 pushed a commit that referenced this issue Feb 25, 2020
@Mema5
feat: implementing the new rule. Build yet to be debugged. Issue #9
c02aa31
Mema5 pushed a commit that referenced this issue Feb 25, 2020
@Mema5
fix: repaired build a priori, issue #9
2ee8ce9
Mema5 pushed a commit that referenced this issue Feb 25, 2020
@Mema5
fix: adapted test suite to respect the new rule. Temporarily removed …
d3b8433 
…some cases to make the test pass. Related to issue #9
Mema5 pushed a commit that referenced this issue Feb 25, 2020
@Mema5
fix: corrected the WPS warnings, issue #9
1af8ffc
Mema5 pushed a commit that referenced this issue Feb 25, 2020
@Mema5
refac: old tests to match the new rule or ignore it, issue #9
e212e1a
Mema5 pushed a commit that referenced this issue Feb 25, 2020
@Mema5
refac: last refactoring. Closes #9
728ea0c
Mema5 added a commit that referenced this issue Feb 25, 2020
@Mema5
tests: refactored tests that now all pass. Closes #9. Related to PR w…
123f365 
…emake-services#1178
@Mema5 Mema5 closed this as completed Feb 25, 2020
ruwaid4 pushed a commit that referenced this issue Mar 7, 2020
@adambenali @hanzhsun
@ChangGabriel @jrutqvist @sobolevn
Issue wemake-services#1172 (wemake-services#1199)
cf3aef9 
* Add ExecutableMismatchViolation #9

* Add logic for ExecutableMismatch

* Add WPS452 to test_noqa.py #5

* Remove dependency and related test

* Implement the full checking logic (#13)

* Fix linting problem (#14)

* Clean up code (#15)

Fix checking logic so that we don't thoroughly check every comment

* Fix permissions (#16)

* Make a new visitor to handle files with 0 comments (#17)

* Add tests for ExecutableMismatchViolation (#18)

* Add ExecutableMismatchViolation #9

* Add WPS452 to test_noqa.py #5

* Remove dependency and related test

* Add test resource files from flake8-executable

* Add tests for check_valid_shebang #7

* Implement the full checking logic (#13)

* Fix linting problem (#14)

* Clean up code (#15)

Fix checking logic so that we don't thoroughly check every comment

* Fix permissions (#16)

* Ignore failing test files

* Update test file to be compatible with the new visitor

* Fix linter issues

* Make a new visitor to handle files with 0 comments (#17)

* Exclude test files from linting

Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com>
Co-authored-by: jrutqvist <joar.rutqvist@gmail.com>
Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com>

* Update CHANGELOG.md

* Moved test resources to fixtures to be ignored by autopep8

* Add integration test

* Refactor tests

* Make the requested changes
Use temporary files for testing

* Update noqa.py

* Make additional requested changes

* Fix small formatting and typing issues

* Update comments.py

* Update comments.py

Co-authored-by: hanzhsu <emily_1999@link.cuhk.edu.hk>
Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com>
Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com>
Co-authored-by: jrutqvist <joar.rutqvist@gmail.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this issue Oct 22, 2020
@Mema5 @fwald @sobolevn
Issue wemake-services#1081: non necessary raw strings (wemake-service…
9dd22ac 
…s#1178)

* feat: added the new violation to be completed, closes #7

* refac: refactor for flake8 consistancy, issue #7

* feat: implementing the new rule. Build yet to be debugged. Issue #9

* test: added a test for violation WPS357. A raw string must contain the '\' character. If there is no '\' in the string a raw string should not be used.
Closes issue #8
Relates to issue#1081 on the original repository

* documentation: Added documentation for the violation RawStringNotNeededViolation (WPS357). Follows the general structure for documentation.
Relates to original issue wemake-services#1081. Closes #11

* fix: Removed an unnecessary single quotation mark in the documentation
relates to #11

* fix: repaired build a priori, issue #9

* fix: adapted test suite to respect the new rule. Temporarily removed some cases to make the test pass. Related to issue #9

* fix: corrected the WPS warnings, issue #9

* fix: enforce the new rule WPS357 in the project itself

* refac: old tests to match the new rule or ignore it, issue #9

* refac: last refactoring. Closes #9

* doc: changelogs for new rule

* test: added a test for wrong case. PR wemake-services#1178

* fix: minor changes required for PR wemake-services#1187

* Doc:
* CHANGELOG.md: new header for release 0.15.0
* added contribution
* Related to PR wemake-services#1178

* test: new tests for rule WPS357. Not passing for escaped quote. PR wemake-services#1178

* fix: correct type and missing newline. PR wemake-services#1178

* tests: refactored tests that now all pass. Closes #9. Related to PR wemake-services#1178

* doc: the previous usage was actually a wrong usage. PR wemake-services#1178

* refac: remove useless encode().decode()

* merged and solve the conflits. All tests pass

* fix: minor changes for PR wemake-services#1178

* fix: error linter wrong indentation, related to PR wemake-services#1178

* fix: wrong error_template in for RawStringNotNeededViolation

* Fixes Ci

* Fixes Ci

Co-authored-by: Mael MADON <mael.madon@polytechnique.edu>
Co-authored-by: fabian.waldner@gmail.com <fabian.waldner@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mema5 Mema5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mema5