Refactor issue #1160 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iZafiro
added a commit
that referenced
this pull request
Mar 1, 2020
* Refactor issue wemake-services#1160 (#25) * Refactor: Refactored function.py to include a @DataClass. * Fix: Added missing comma to function.py. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Changed wrong frozen=False tag. * Fix: Changed default to factory. * Fix: Fixed lint errors. * Fix: Added defaultDict variable to dataclass. * Fix: Lint fix. * Refactor: Finish refactoring dataclass. * Fix: Fixed lint errors. * Fix: Fixed lint errors. * Fix: Fixed test errors.
sobolevn
pushed a commit
that referenced
this pull request
Oct 22, 2020
Test: Adds tests for TooManyRaisesViolation which for now are disabled Test: * Adds false positivity test with 3 raises in method * Adds false positivity test with 4 raises in module * Fixes wrong number of raises in tests * Fixes string literals in tests to be more pythonic Fix: fixes test for python 3.8 Docs: Document TooManyRaisesViolation rule. Issue #16 (#20) Merge branches Issue #14 (#21) * Feat: Implement TooManyRaisesViolation rule and config. Issue #14 * Fix: A priori fix for I001 and WPS230 lint failures. Issue #14 * Fix: A priori fix for AssertionError related to tests. Issue #14 * Fix: Modify test_public_attrs_count tests to ignore class _ComplexityCounter. Issue #14 * Fix: Sort imports in test_public_attrs_count. Issue #14 * Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14 * Fix: Undo a few commits and restore defaults. Issue #14 * Refactor: Create class _ComplexityExitMetrics(object). Issue #14 * Fix: (Temporarily) remove decorator @DataClass from class _ComplexityExitMetrics(object). Issue #14 * Fix: Added _ at the beginning of a public attribute in class _ComplexityCounter(object). Issue #14 * Fix: Added = to define a public attribute in class _ComplexityCounter(object). Issue #14 * Fix: Fix various lint errors. Issue #14 * Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14 * Test: Added Gwin73's fixes for his tests. Issue #14 * Fix: fixes incorrect annotation for test * Fix for python 3.8 Co-authored-by: Adrian Westerberg <adrianwesterberg@hotmail.com> Test: Removes integration tests and add unit tests which right now fail Fix: Fixed a few lint errrors in test_raises_count.py. Issue #15 Issue #15 (#23) * Test: Created new tests for issue 3. Issue #15 * Test: Modified WPS235 in test_noqa.py. Issue #15 Co-authored-by: iZafiro <60047972+iZafiro@users.noreply.github.com> Docs: Added WPS235 to CHANGELOG.md. Issue wemake-services#1160 Docs: Changed weird comment in test_raises.py. Issue wemake-services#1160 Doc: Fixes doc Test: Simplifies integration test Test: Adds more tests Fix: Changes code of violation to make merge easier Refac: changes imports and formatting after rebasing. Refact issue wemake-services#1160 (#26) * Refactor issue wemake-services#1160 (#25) * Refactor: Refactored function.py to include a @DataClass. * Fix: Added missing comma to function.py. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Changed wrong frozen=False tag. * Fix: Changed default to factory. * Fix: Fixed lint errors. * Fix: Added defaultDict variable to dataclass. * Fix: Lint fix. * Refactor: Finish refactoring dataclass. * Fix: Fixed lint errors. * Fix: Fixed lint errors. * Fix: Fixed test errors.
sobolevn
added a commit
that referenced
this pull request
Feb 6, 2021
* Feat: adds stub of the new violation TooManyRaisesViolation Test: Adds tests for TooManyRaisesViolation which for now are disabled Test: * Adds false positivity test with 3 raises in method * Adds false positivity test with 4 raises in module * Fixes wrong number of raises in tests * Fixes string literals in tests to be more pythonic Fix: fixes test for python 3.8 Docs: Document TooManyRaisesViolation rule. Issue #16 (#20) Merge branches Issue #14 (#21) * Feat: Implement TooManyRaisesViolation rule and config. Issue #14 * Fix: A priori fix for I001 and WPS230 lint failures. Issue #14 * Fix: A priori fix for AssertionError related to tests. Issue #14 * Fix: Modify test_public_attrs_count tests to ignore class _ComplexityCounter. Issue #14 * Fix: Sort imports in test_public_attrs_count. Issue #14 * Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14 * Fix: Undo a few commits and restore defaults. Issue #14 * Refactor: Create class _ComplexityExitMetrics(object). Issue #14 * Fix: (Temporarily) remove decorator @DataClass from class _ComplexityExitMetrics(object). Issue #14 * Fix: Added _ at the beginning of a public attribute in class _ComplexityCounter(object). Issue #14 * Fix: Added = to define a public attribute in class _ComplexityCounter(object). Issue #14 * Fix: Fix various lint errors. Issue #14 * Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14 * Test: Added Gwin73's fixes for his tests. Issue #14 * Fix: fixes incorrect annotation for test * Fix for python 3.8 Co-authored-by: Adrian Westerberg <adrianwesterberg@hotmail.com> Test: Removes integration tests and add unit tests which right now fail Fix: Fixed a few lint errrors in test_raises_count.py. Issue #15 Issue #15 (#23) * Test: Created new tests for issue 3. Issue #15 * Test: Modified WPS235 in test_noqa.py. Issue #15 Co-authored-by: iZafiro <60047972+iZafiro@users.noreply.github.com> Docs: Added WPS235 to CHANGELOG.md. Issue wemake-services#1160 Docs: Changed weird comment in test_raises.py. Issue wemake-services#1160 Doc: Fixes doc Test: Simplifies integration test Test: Adds more tests Fix: Changes code of violation to make merge easier Refac: changes imports and formatting after rebasing. Refact issue wemake-services#1160 (#26) * Refactor issue wemake-services#1160 (#25) * Refactor: Refactored function.py to include a @DataClass. * Fix: Added missing comma to function.py. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix syntax errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix lint errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Tried to fix test errors. * Fix: Changed wrong frozen=False tag. * Fix: Changed default to factory. * Fix: Fixed lint errors. * Fix: Added defaultDict variable to dataclass. * Fix: Lint fix. * Refactor: Finish refactoring dataclass. * Fix: Fixed lint errors. * Fix: Fixed lint errors. * Fix: Fixed test errors. * Fixes merge * Fixes merge * Fixes merge Co-authored-by: Gwin73 <adrianwesterberg@hotmail.com> Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean commit history