Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-#1160 implement the rule #14

Closed
adrwes opened this issue Feb 23, 2020 · 0 comments
Closed

issue-#1160 implement the rule #14

adrwes opened this issue Feb 23, 2020 · 0 comments
Assignees
@iZafiro

Comments

@adrwes
Copy link
Owner

adrwes commented Feb 23, 2020

No description provided.

@iZafiro iZafiro self-assigned this Feb 24, 2020
iZafiro pushed a commit that referenced this issue Feb 24, 2020
Feat: Implement TooManyRaisesViolation rule and config. Issue #14
6524c7d
iZafiro pushed a commit that referenced this issue Feb 24, 2020
Fix: A priori fix for I001 and WPS230 lint failures. Issue #14
efc83ac
iZafiro pushed a commit that referenced this issue Feb 24, 2020
Fix: A priori fix for AssertionError related to tests. Issue #14
1a5b22b
iZafiro added a commit that referenced this issue Feb 24, 2020
@iZafiro
Fix: Modify test_public_attrs_count tests to ignore class _Complexity…
fa077ca 
…Counter. Issue #14
iZafiro added a commit that referenced this issue Feb 24, 2020
@iZafiro
Fix: Sort imports in test_public_attrs_count. Issue #14
363d794
iZafiro added a commit that referenced this issue Feb 24, 2020
@iZafiro
Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14
3456fdf
iZafiro added a commit that referenced this issue Feb 24, 2020
@iZafiro
Fix: Undo a few commits and restore defaults. Issue #14
e60cad7
iZafiro added a commit that referenced this issue Feb 24, 2020
@iZafiro
Refactor: Create class _ComplexityExitMetrics(object). Issue #14
7837dec
iZafiro added a commit that referenced this issue Feb 24, 2020
@iZafiro
Fix: (Temporarily) remove decorator @DataClass from class _Complexity…
d8b3eef 
…ExitMetrics(object). Issue #14
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro
Fix: Added _ at the beginning of a public attribute in class _Complex…
1a26d22 
…ityCounter(object). Issue #14
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro
Fix: Added = to define a public attribute in class _ComplexityCounter…
29f9ee8 
…(object). Issue #14
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro
Fix: Fix various lint errors. Issue #14
5fab721
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro
Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14
f30fbbf
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro
Test: Added Gwin73's fixes for his tests. Issue #14
5afbbbb
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro
Merge branch 'issue-wemake-services#1160' into issue-#14
8db35f7
iZafiro added a commit that referenced this issue Feb 25, 2020
@iZafiro @adrwes
Issue #14 (#21)
4e60320 
* Feat: Implement TooManyRaisesViolation rule and config. Issue #14

* Fix: A priori fix for I001 and WPS230 lint failures. Issue #14

* Fix: A priori fix for AssertionError related to tests. Issue #14

* Fix: Modify test_public_attrs_count tests to ignore class _ComplexityCounter. Issue #14

* Fix: Sort imports in test_public_attrs_count. Issue #14

* Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14

* Fix: Undo a few commits and restore defaults. Issue #14

* Refactor: Create class _ComplexityExitMetrics(object). Issue #14

* Fix: (Temporarily) remove decorator @DataClass from class _ComplexityExitMetrics(object). Issue #14

* Fix: Added _ at the beginning of a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Added = to define a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Fix various lint errors. Issue #14

* Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14

* Test: Added Gwin73's fixes for his tests. Issue #14

* Fix: fixes incorrect annotation for test

* Fix for python 3.8

Co-authored-by: Adrian Westerberg <adrianwesterberg@hotmail.com>
@iZafiro iZafiro closed this as completed Feb 25, 2020
Mema5 pushed a commit that referenced this issue Feb 28, 2020
@iZafiro @adrwes @Mema5
Issue #14 (#21)
c70aaa1 
* Feat: Implement TooManyRaisesViolation rule and config. Issue #14

* Fix: A priori fix for I001 and WPS230 lint failures. Issue #14

* Fix: A priori fix for AssertionError related to tests. Issue #14

* Fix: Modify test_public_attrs_count tests to ignore class _ComplexityCounter. Issue #14

* Fix: Sort imports in test_public_attrs_count. Issue #14

* Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14

* Fix: Undo a few commits and restore defaults. Issue #14

* Refactor: Create class _ComplexityExitMetrics(object). Issue #14

* Fix: (Temporarily) remove decorator @DataClass from class _ComplexityExitMetrics(object). Issue #14

* Fix: Added _ at the beginning of a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Added = to define a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Fix various lint errors. Issue #14

* Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14

* Test: Added Gwin73's fixes for his tests. Issue #14

* Fix: fixes incorrect annotation for test

* Fix for python 3.8

Co-authored-by: Adrian Westerberg <adrianwesterberg@hotmail.com>
ruwaid4 pushed a commit that referenced this issue Mar 7, 2020
@adambenali @hanzhsun
@ChangGabriel @jrutqvist @sobolevn
Issue wemake-services#1172 (wemake-services#1199)
cf3aef9 
* Add ExecutableMismatchViolation #9

* Add logic for ExecutableMismatch

* Add WPS452 to test_noqa.py #5

* Remove dependency and related test

* Implement the full checking logic (#13)

* Fix linting problem (#14)

* Clean up code (#15)

Fix checking logic so that we don't thoroughly check every comment

* Fix permissions (#16)

* Make a new visitor to handle files with 0 comments (#17)

* Add tests for ExecutableMismatchViolation (#18)

* Add ExecutableMismatchViolation #9

* Add WPS452 to test_noqa.py #5

* Remove dependency and related test

* Add test resource files from flake8-executable

* Add tests for check_valid_shebang #7

* Implement the full checking logic (#13)

* Fix linting problem (#14)

* Clean up code (#15)

Fix checking logic so that we don't thoroughly check every comment

* Fix permissions (#16)

* Ignore failing test files

* Update test file to be compatible with the new visitor

* Fix linter issues

* Make a new visitor to handle files with 0 comments (#17)

* Exclude test files from linting

Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com>
Co-authored-by: jrutqvist <joar.rutqvist@gmail.com>
Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com>

* Update CHANGELOG.md

* Moved test resources to fixtures to be ignored by autopep8

* Add integration test

* Refactor tests

* Make the requested changes
Use temporary files for testing

* Update noqa.py

* Make additional requested changes

* Fix small formatting and typing issues

* Update comments.py

* Update comments.py

Co-authored-by: hanzhsu <emily_1999@link.cuhk.edu.hk>
Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com>
Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com>
Co-authored-by: jrutqvist <joar.rutqvist@gmail.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn pushed a commit that referenced this issue Oct 22, 2020
@adrwes @sobolevn
Feat: adds stub of the new violation TooManyRaisesViolation
bb3fc0b 
Test: Adds tests for TooManyRaisesViolation which for now are disabled

Test:
* Adds false positivity test with 3 raises in method
* Adds false positivity test with 4 raises in module
* Fixes wrong number of raises in tests
* Fixes string literals in tests to be more pythonic

Fix: fixes test for python 3.8

Docs: Document TooManyRaisesViolation rule. Issue #16 (#20)

Merge branches

Issue #14 (#21)

* Feat: Implement TooManyRaisesViolation rule and config. Issue #14

* Fix: A priori fix for I001 and WPS230 lint failures. Issue #14

* Fix: A priori fix for AssertionError related to tests. Issue #14

* Fix: Modify test_public_attrs_count tests to ignore class _ComplexityCounter. Issue #14

* Fix: Sort imports in test_public_attrs_count. Issue #14

* Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14

* Fix: Undo a few commits and restore defaults. Issue #14

* Refactor: Create class _ComplexityExitMetrics(object). Issue #14

* Fix: (Temporarily) remove decorator @DataClass from class _ComplexityExitMetrics(object). Issue #14

* Fix: Added _ at the beginning of a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Added = to define a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Fix various lint errors. Issue #14

* Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14

* Test: Added Gwin73's fixes for his tests. Issue #14

* Fix: fixes incorrect annotation for test

* Fix for python 3.8

Co-authored-by: Adrian Westerberg <adrianwesterberg@hotmail.com>

Test: Removes integration tests and add unit tests which right now fail

Fix: Fixed a few lint errrors in test_raises_count.py. Issue #15

Issue #15 (#23)

* Test: Created new tests for issue 3. Issue #15

* Test: Modified WPS235 in test_noqa.py. Issue #15

Co-authored-by: iZafiro <60047972+iZafiro@users.noreply.github.com>

Docs: Added WPS235 to CHANGELOG.md. Issue wemake-services#1160

Docs: Changed weird comment in test_raises.py. Issue wemake-services#1160

Doc: Fixes doc

Test: Simplifies integration test

Test: Adds more tests

Fix: Changes code of violation to make merge easier

Refac: changes imports and formatting after rebasing.

Refact issue wemake-services#1160 (#26)

* Refactor issue wemake-services#1160 (#25)

* Refactor: Refactored function.py to include a @DataClass.

* Fix: Added missing comma to function.py.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Changed wrong frozen=False tag.

* Fix: Changed default to factory.

* Fix: Fixed lint errors.

* Fix: Added defaultDict variable to dataclass.

* Fix: Lint fix.

* Refactor: Finish refactoring dataclass.

* Fix: Fixed lint errors.

* Fix: Fixed lint errors.

* Fix: Fixed test errors.
sobolevn added a commit that referenced this issue Feb 6, 2021
@iZafiro @adrwes @sobolevn
Issue wemake-services#1160 (wemake-services#1198)
aedf714 
* Feat: adds stub of the new violation TooManyRaisesViolation

Test: Adds tests for TooManyRaisesViolation which for now are disabled

Test:
* Adds false positivity test with 3 raises in method
* Adds false positivity test with 4 raises in module
* Fixes wrong number of raises in tests
* Fixes string literals in tests to be more pythonic

Fix: fixes test for python 3.8

Docs: Document TooManyRaisesViolation rule. Issue #16 (#20)

Merge branches

Issue #14 (#21)

* Feat: Implement TooManyRaisesViolation rule and config. Issue #14

* Fix: A priori fix for I001 and WPS230 lint failures. Issue #14

* Fix: A priori fix for AssertionError related to tests. Issue #14

* Fix: Modify test_public_attrs_count tests to ignore class _ComplexityCounter. Issue #14

* Fix: Sort imports in test_public_attrs_count. Issue #14

* Fix: Try to avoid lint failures in test_public_attrs_count. Issue #14

* Fix: Undo a few commits and restore defaults. Issue #14

* Refactor: Create class _ComplexityExitMetrics(object). Issue #14

* Fix: (Temporarily) remove decorator @DataClass from class _ComplexityExitMetrics(object). Issue #14

* Fix: Added _ at the beginning of a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Added = to define a public attribute in class _ComplexityCounter(object). Issue #14

* Fix: Fix various lint errors. Issue #14

* Docs: Changed docs for class _ComplexityExitMetrics(object). Issue #14

* Test: Added Gwin73's fixes for his tests. Issue #14

* Fix: fixes incorrect annotation for test

* Fix for python 3.8

Co-authored-by: Adrian Westerberg <adrianwesterberg@hotmail.com>

Test: Removes integration tests and add unit tests which right now fail

Fix: Fixed a few lint errrors in test_raises_count.py. Issue #15

Issue #15 (#23)

* Test: Created new tests for issue 3. Issue #15

* Test: Modified WPS235 in test_noqa.py. Issue #15

Co-authored-by: iZafiro <60047972+iZafiro@users.noreply.github.com>

Docs: Added WPS235 to CHANGELOG.md. Issue wemake-services#1160

Docs: Changed weird comment in test_raises.py. Issue wemake-services#1160

Doc: Fixes doc

Test: Simplifies integration test

Test: Adds more tests

Fix: Changes code of violation to make merge easier

Refac: changes imports and formatting after rebasing.

Refact issue wemake-services#1160 (#26)

* Refactor issue wemake-services#1160 (#25)

* Refactor: Refactored function.py to include a @DataClass.

* Fix: Added missing comma to function.py.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix syntax errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix lint errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Tried to fix test errors.

* Fix: Changed wrong frozen=False tag.

* Fix: Changed default to factory.

* Fix: Fixed lint errors.

* Fix: Added defaultDict variable to dataclass.

* Fix: Lint fix.

* Refactor: Finish refactoring dataclass.

* Fix: Fixed lint errors.

* Fix: Fixed lint errors.

* Fix: Fixed test errors.

* Fixes merge

* Fixes merge

* Fixes merge

Co-authored-by: Gwin73 <adrianwesterberg@hotmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iZafiro iZafiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrwes @iZafiro