prefer bibgroup and bibgroup_facets from nonbib #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update pipeline utils release to get latest protobufs
marblestation
approved these changes
May 4, 2021
| @@ -1,4 +1,4 @@ | |||
| adsputils==1.2.8 | |||
| adsputils==1.3.0 | |||
There was a problem hiding this comment.
I believe this version is python 3 compatible only, which would make this version of master python 3 compatible only. You may want to hold this change for when you decide to deploy master with Python 3.
There was a problem hiding this comment.
I'll add python3 support to this pull request.
adsmp/solr_updater.py
Outdated
Comment on lines
327
to
330
| if db_record.get('nonbib_data', None) and db_record['nonbib_data'].get('bibgroup'): | ||
| out['bibgroup'] = db_record['nonbib_data']['bibgroup'] | ||
| if db_record.get('nonbib_data', None) and db_record['nonbib_data'].get('bibgroup_facet'): | ||
| out['bibgroup_facet'] = db_record['nonbib_data']['bibgroup_facet'] |
There was a problem hiding this comment.
We are repeating the same condition verification twice (i.e., db_record.get('nonbib_data', None)), we could have a nested if to remove that dup. Also, given that we are not using the returned value, we could just use if 'nonbib_data' in db_record (as you prefer).
added 2 commits
May 5, 2021 13:29
also requires changes to file /app/reindex.py which is in BeeHive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update pipeline utils release to get latest protobufs