Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added deletion of obsolete recs into run.py #165

Merged
merged 1 commit into from
Dec 13, 2021
Merged

feat: added deletion of obsolete recs into run.py #165

merged 1 commit into from
Dec 13, 2021

Conversation

romanchyla
Copy link
Contributor

No description provided.

marblestation
marblestation approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@marblestation marblestation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only thing that will be confusing is using --since when in reality we well delete records up to that date, but we can change this later if necessary.

@marblestation marblestation merged commit 86670a3 into adsabs:master Dec 13, 2021
marblestation
marblestation approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@marblestation marblestation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only thing that will be confusing is using --since when in reality we well delete records up to that date, but we can change this later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marblestation marblestation marblestation approved these changes

@nemanjamart nemanjamart Awaiting requested review from nemanjamart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanchyla @marblestation