Merge pull request #2081 from thostetler/fix-search-examples

Fixes for search examples
adsabs · Nov 19, 2020 · d53e5e7 · d53e5e7
2 parents 2ef87f4 + a40a0f9
commit d53e5e7
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 14 deletions.
diff --git a/src/js/react/Recommender/components/SearchExamples.jsx.js b/src/js/react/Recommender/components/SearchExamples.jsx.js
@@ -25,7 +25,12 @@ define([
       <React.Fragment>
         <dt>{label}</dt>
         <dd>
-          <button type="button" onClick={onClick} className="text-link">
+          <button
+            type="button"
+            onClick={onClick}
+            className="text-link"
+            style={{ border: 'dotted 1px rgba(0,0,0,0.3)', marginRight: '4px' }}
+          >
             {text}
           </button>
           {tooltip && (
@@ -62,27 +67,36 @@ define([
     };
 
     return (
-      <div style={{ paddingTop: '1rem' }}>
-        <div className="col-sm-5 quick-reference">
+      <div
+        style={{
+          paddingTop: '1rem',
+          display: 'flex',
+          justifyContent: 'space-between',
+          flexWrap: 'wrap',
+        }}
+      >
+        <div className="quick-reference">
           <Dl>
             {searchExamples.slice(0, 7).map((entry) => (
               <Entry
                 label={entry.label}
                 text={entry.example}
                 tooltip={entry.tooltip}
                 onClick={() => onClick(entry.example)}
+                key={entry.label}
               />
             ))}
           </Dl>
         </div>
-        <div className="col-sm-7 quick-reference">
+        <div className="quick-reference">
           <Dl>
             {searchExamples.slice(7).map((entry) => (
               <Entry
                 label={entry.label}
                 text={entry.example}
                 tooltip={entry.tooltip}
                 onClick={() => onClick(entry.example)}
+                key={entry.label}
               />
             ))}
           </Dl>

diff --git a/src/js/widgets/search_bar/search_bar_widget.js b/src/js/widgets/search_bar/search_bar_widget.js
@@ -344,16 +344,6 @@ define([
       });
 
       this.$('[data-toggle="tooltip"]').tooltip();
-
-      // this is for search examples, sets form value on click
-      this.$('.search-quick-links button').on('click', (e) => {
-        const value = e.currentTarget.innerText.trim();
-
-        if (value) {
-          this.setFormVal(`${this.getFormVal()} ${value}`);
-          this.$input.focus();
-        }
-      });
     },
 
     events: {
@@ -772,6 +762,12 @@ define([
           $input.select();
           $(document.documentElement).scrollTop(0);
         }
+      } else if (event === 'recommender/update-search-text') {
+        const value = arg.text;
+        if (value) {
+          this.view.setFormVal(`${this.view.getFormVal()} ${value}`);
+          this.view.$input.focus();
+        }
       }
     },