Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Host and amazon trace id #26

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

romanchyla
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.933% when pulling dceffbc on romanchyla:tracing into ca87842 on adsabs:master.

@taylorshaulis taylorshaulis merged commit c81aacf into adsabs:master Mar 19, 2018
@taylorshaulis
Copy link
Collaborator

I had to revert this PR. Solr-service was no longer generating valid HTTP requests (status 400)

I am going to run locally to try to tcpdump to figure out why nginx and nodejs no longer consider these requests valid

@taylorshaulis
Copy link
Collaborator

Ok this should be the same as PR 26 except for the def _get_host(self, url): function in solr/view.py has been modified so that it only returns the hostname and not http://hostname

I have tested this in Dev and both host and x-amzn-trace-id work now

2018-03-19 17:21:05.580 INFO (qtp97730845-15) [ x:collection1] o.a.s.c.S.Request [collection1] webapp=/solr path=/select params={q=references(bibcode:2012A%26A...544A..53G)&x-amzn-trace-id=Root%3D1-5aaff180-44e85d08b6342f489b5c4e8a&fl=title,bibcode,author,keyword,pub,aff,volume,year,links_data,[citations],property,pubdate,abstract&start=0&sort=first_author+asc&rows=25&wt=json} hits=21 status=0 QTime=168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants