Revert "Revert "Added Host and amazon trace id"" #28
Conversation
| """Just extracts the host from the url.""" | ||
| return self._host or self._get_host(url) | ||
|
|
||
| def _get_host(self, url): |
There was a problem hiding this comment.
This part is what I changed from the original PR
We want host to only be hostname so I removed the http://
|
Ok this should be the same as #26 except for the def _get_host(self, url): function in solr/view.py has been modified so that it only returns the hostname and not http://hostname I have tested this in Dev and both host and x-amzn-trace-id work now 2018-03-19 17:21:05.580 INFO (qtp97730845-15) [ x:collection1] o.a.s.c.S.Request [collection1] webapp=/solr path=/select params={q=references(bibcode:2012A%26A...544A..53G)&x-amzn-trace-id=Root%3D1-5aaff180-44e85d08b6342f489b5c4e8a&fl=title,bibcode,author,keyword,pub,aff,volume,year,links_data,[citations],property,pubdate,abstract&start=0&sort=first_author+asc&rows=25&wt=json} hits=21 status=0 QTime=168 |
|
updated the failing test, the port is still there - hope that's OK with kubernetes |
Going to try this again
Reverts #27