-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected urls #79
corrected urls #79
Conversation
corrected urls for css and js
Add route to count comments, add count to GET request result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it looks like you merged it smbkr's PR into your fork. You don't have to do this: you can maintain your fork independent of what happens in the original. I am not entirely sure what you have to do to fix this (I'm guessing it's going to take a interactive rebase and then removing the two extra commits).
And then you'll want to do a pull from master. To do this, run git pull --rebase origin master
. You'll hopefully not face any merge conflicts.
@@ -47,7 +47,7 @@ Now you can embed Commento on your webpage. A trivial page would look like: | |||
```html | |||
<html> | |||
<head> | |||
<script src="http://127.0.0.1:8080/assets/commento.min.js"></script> | |||
<script src="http://127.0.0.1:8080/assets/js/commento.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be a min
file, no? You'll have to generate them now though
unack a5804d7 |
It's been a few months since the original PR, so I don't think I can merge this anymore. The proposed changes have been merged as well. Closing this PR. |
corrected urls for css and js