Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected urls #79

Closed
wants to merge 3 commits into from
Closed

corrected urls #79

wants to merge 3 commits into from

Conversation

skorotkiewicz
Copy link

corrected urls for css and js

corrected urls for css and js
@adtac adtac added size/L and removed size/S labels May 16, 2017
Copy link
Owner

@adtac adtac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it looks like you merged it smbkr's PR into your fork. You don't have to do this: you can maintain your fork independent of what happens in the original. I am not entirely sure what you have to do to fix this (I'm guessing it's going to take a interactive rebase and then removing the two extra commits).

And then you'll want to do a pull from master. To do this, run git pull --rebase origin master. You'll hopefully not face any merge conflicts.

@@ -47,7 +47,7 @@ Now you can embed Commento on your webpage. A trivial page would look like:
```html
<html>
<head>
<script src="http://127.0.0.1:8080/assets/commento.min.js"></script>
<script src="http://127.0.0.1:8080/assets/js/commento.js"></script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be a min file, no? You'll have to generate them now though

@adtac adtac added wip and removed pending review labels May 19, 2017
@adtac
Copy link
Owner

adtac commented May 19, 2017

unack a5804d7

@adtac
Copy link
Owner

adtac commented Nov 8, 2017

It's been a few months since the original PR, so I don't think I can merge this anymore. The proposed changes have been merged as well. Closing this PR.

@adtac adtac closed this Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants