-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 error on using editable link #53
Comments
Hi @barteksekula The 404 issue I am getting is not same as globalisation Url issue due to language fragment. In my case even after removing the language fragment the (Created as Edit) editable external reviewer urls are returning 404 error while View only external reviewer urls are working fine. Is this something you have already fixed? Please read more details in comment above. Thanks! |
@karorapepper I've just checked once again to be sure but everything seems to work just fine. Could you please share more details? What user are you trying to log on after opening 'externalContentReviews/' path? Please try with https://nuget.episerver.com/package/?id=Advanced.CMS.AdvancedReviews&v=0.2.1 and let us know. |
Restructure solution Approved-by: Grzegorz Wiecheć <gregorwiechec@gmail.com>
@karorapepper did this work for you? |
hey @barteksekula, nope the issue not resolved yet, the editable reviewer link still gives 404. I assumed it may have something to do with permissions setup for content editor user roles which is not allowing to create pages in editable mode. However my content editor/reviewers only needed viewable links hence didn't pursue for the solution. Though would be good to find a solution. |
Also @barteksekula from your previous comment I think you are mixing two different issues I was talking about -
|
Regression after #64. When setting the token to a draft version it is not possible to render the page (access denied). But the token is needed because otherwise it is always the StartPage that is set in currentContentContext.Content in ContentPropertiesStack. Using an ID without workid solves the problem, correct data-epi-property-name attributes are rendered. Closes #71 CLoses #74 Closes #53
Regression after #64. When setting the token to a draft version it is not possible to render the page (access denied). But the token is needed because otherwise it is always the StartPage that is set in currentContentContext.Content in ContentPropertiesStack. Using an ID without workid solves the problem, correct data-epi-property-name attributes are rendered. Closes #71 CLoses #74 Closes #53
Regression after #64. When setting the token to a draft version it is not possible to render the page (access denied). But the token is needed because otherwise it is always the StartPage that is set in currentContentContext.Content in ContentPropertiesStack. This fix will make sure that the Authorize filter will not be used when the request is in external review context. Closes #71 CLoses #74 Closes #53
@karorapepper does it work for you now? |
It has to be done here, after the routing is already done and before controller render the HTML Closes #53
If anyone hits issues like this, please check that you have correct entries in web.config: <location path="externalContentReviews">
<system.web>
<authorization>
<allow roles="ExternalReviewers" />
<deny users="*" />
</authorization>
</system.web>
</location><location path="EPiServer/advanced-cms.ExternalReviews">
<system.web>
<authorization>
<allow roles="ExternalReviewers, WebEditors, WebAdmins, Administrators" />
<deny users="*" />
</authorization>
</system.web>
</location> |
We should also allow regular editors to use External reviews. We can also reuse the default controller urls provided by cms ui. i.e. /modulename/controller/action instead of registering custom urls for external component and review avatars. Only edit mode users should have access to those anyway. #202 #167 #74 #53
We should also allow regular editors to use External reviews. We can also reuse the default controller urls provided by cms ui. i.e. /modulename/controller/action instead of registering custom urls for external component and review avatars. Only edit mode users should have access to those anyway. #202 #167 #74 #53
Hi,
Thanks for creating this very useful addon.
However I am getting 404 error on loading the Editable External Review link. I am able to use rest of the features fine. The view only link works well too (although it adds an additional /en before /externalContentView resulting in 404 as well but was able to get around that by adding redirect to remove /en) but edit link keeps giving 404 error. Can anyone help in this regard?
I have already added the ExternalReviewInitialization file and set EdiatbleLinksEnabled option to true.
Another question what is the use of following 3 ExternalReviewOptions:
public string ReviewsUrl { get; set; }
public string ContentPreviewUrl { get; set; }
public string ContentIframeEditUrlSegment { get; set; }
Thanks.
The text was updated successfully, but these errors were encountered: