Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable argument-mismatch errors for SPEC CPU2006 416.gamess for GCC >= 8 #549

Closed
tuliom opened this issue Jul 17, 2018 · 1 comment
Closed
Assignees
Labels

Comments

@tuliom
Copy link
Contributor

tuliom commented Jul 17, 2018

gfortran 8 is able to detect a new warning/error that is causing SPEC CPU2006 416.gamess to fail:

ecp.fppized.f:402:15:

       CALL ZFN(ZFNLM,NPNP-1,ZLM,LMF,LMX,LMY,LMZ)
               1
Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)
ecp.fppized.f:544:18:

          CALL ZFN(ZFNLM,NPNP-1,ZLM,LMF,LMX,LMY,LMZ)
                  1
Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)
ecp.fppized.f:739:24:

                CALL ZFN(ZFNLM,NPNP-1,ZLM,LMF,LMX,LMY,LMZ)
                        1
Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)
ecp.fppized.f:994:18:

          CALL ZFN(ZFNLMC,NPCPL-1,ZLM,LMF,LMX,LMY,LMZ)
                  1
Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)
ecp.fppized.f:998:18:

          CALL ZFN(ZFNLMB,NPBPL-1,ZLM,LMF,LMX,LMY,LMZ)
                  1
Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)
specmake: *** [ecp.fppized.o] Error 1
specmake: *** Waiting for unfinished jobs....

As far as I can see, we need to pass -Wno-error=argument-mismatch to 416.gamess.

@tuliom tuliom added the bug label Jul 17, 2018
@inconstante inconstante self-assigned this Jul 18, 2018
inconstante added a commit to inconstante/advance-toolchain that referenced this issue Jul 18, 2018
Since GCC 8.1, gfortran issues an error "when an actual argument
contains too few elements for a dummy argument" [1].  This behaviour
breaks the build of 416.gamess, with error messages similar to:

    ecp.fppized.f:402:15:

           CALL ZFN(ZFNLM,NPNP-1,ZLM,LMF,LMX,LMY,LMZ)
                   1
    Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)

as described more thoroughly in bug report advancetoolchain#549 [2].

This patch adds gfortran's '-std=legacy' option (via 'FPORTABILITY') to
the configuration file for SPEC CPU2006 tests, as suggested by the
release notes for GCC 8.1 [1].

[1] https://gcc.gnu.org/gcc-8/changes.html#fortran

[2] advancetoolchain#549

Signed-off-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
@tuliom
Copy link
Contributor Author

tuliom commented Jul 19, 2018

@gftg85 found out the suggested solution for this problem is to use -std=legacy, instead of what I suggested in the description of the bug.

inconstante added a commit that referenced this issue Jul 19, 2018
Since GCC 8.1, gfortran issues an error "when an actual argument
contains too few elements for a dummy argument" [1].  This behaviour
breaks the build of 416.gamess, with error messages similar to:

    ecp.fppized.f:402:15:

           CALL ZFN(ZFNLM,NPNP-1,ZLM,LMF,LMX,LMY,LMZ)
                   1
    Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)

as described more thoroughly in bug report #549 [2].

This patch adds gfortran's '-std=legacy' option (via 'FPORTABILITY') to
the configuration file for SPEC CPU2006 tests, as suggested by the
release notes for GCC 8.1 [1].

[1] https://gcc.gnu.org/gcc-8/changes.html#fortran

[2] #549

Signed-off-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants