Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPEC CPU2006 config file for AT 12.0 (GCC 8) #551

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Fix SPEC CPU2006 config file for AT 12.0 (GCC 8) #551

merged 1 commit into from
Jul 19, 2018

Conversation

inconstante
Copy link
Contributor

@inconstante inconstante commented Jul 18, 2018 •
edited

Fix #549.

(EDIT: Tested on a SLES 12 powerpc64le server)

@inconstante
Fix SPEC CPU2006 config file for AT 12.0 (GCC 8)
a08e0a1 
Since GCC 8.1, gfortran issues an error "when an actual argument
contains too few elements for a dummy argument" [1].  This behaviour
breaks the build of 416.gamess, with error messages similar to:

    ecp.fppized.f:402:15:

           CALL ZFN(ZFNLM,NPNP-1,ZLM,LMF,LMX,LMY,LMZ)
                   1
    Error: Actual argument contains too few elements for dummy argument 'zfnlm' (121/125) at (1)

as described more thoroughly in bug report advancetoolchain#549 [2].

This patch adds gfortran's '-std=legacy' option (via 'FPORTABILITY') to
the configuration file for SPEC CPU2006 tests, as suggested by the
release notes for GCC 8.1 [1].

[1] https://gcc.gnu.org/gcc-8/changes.html#fortran

[2] advancetoolchain#549

Signed-off-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
tuliom
tuliom approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@tuliom tuliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that GCC 6 does support -std=legacy, so LGTM.

@inconstante
Copy link
Contributor Author

Thanks, your attention to details is greatly appreciated. :D

Now tested that it works correctly for AT 10.0. Below, a snippet from the output of an FVTR run with AT 10.0 (which ends successfully):

/opt/at10.0/bin/gfortran -c -o basecp.fppized.o -m64 -O3 -fpeel-loops -funroll-loops -ffast-math -fvect-cost-model -mrecip=rsqrt -std=legacy -fno-aggressive-loop-optimizations -funconstrained-commons basecp.fppized.f

@inconstante inconstante merged commit 8a7e882 into advancetoolchain:master Jul 19, 2018
@inconstante inconstante deleted the speccpu2006 branch July 19, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliom tuliom tuliom approved these changes

@RajalakshmiS RajalakshmiS RajalakshmiS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inconstante @tuliom @RajalakshmiS