Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs with Pasting in ALPS Gutenberg Blocks #25

Closed
6 tasks done
designerbrent opened this issue May 5, 2020 · 1 comment · Fixed by #28
Closed
6 tasks done

Bugs with Pasting in ALPS Gutenberg Blocks #25

designerbrent opened this issue May 5, 2020 · 1 comment · Fixed by #28
Assignees
@tpitre @kelscahill
Labels
bug Something isn't working

Comments

@designerbrent
Copy link
Collaborator

designerbrent commented May 5, 2020 •
edited

Problem

After working with @kelscahill on the Media Testimonies Block, we found that there is an issue with not being able to paste when the isSelected: false property is set.

Solution:

We need to make sure that the following blocks can all have text pasted into them:

  • ALPS Blockquote
  • ALPS CTA
  • ALPS Content Block
  • ALPS Accordion
  • ALPS Content Expand
  • ALPS Content Show More
@designerbrent designerbrent added the bug Something isn't working label May 5, 2020
@designerbrent designerbrent mentioned this issue May 5, 2020
Closed
3 tasks
kelscahill added a commit that referenced this issue May 8, 2020
@kelscahill
Resolves #25, #26, #27 - Updates and cleans up react code. Adds richt…
4e7df32 
…ext editing.
@kelscahill kelscahill mentioned this issue May 8, 2020
Merged
@kelscahill
Copy link
Collaborator

@designerbrent All these issue are updated and within this PR: #28

designerbrent added a commit that referenced this issue May 11, 2020
@designerbrent
Merge pull request #28 from adventistchurch/v3.block-updates
5b2bfd6 
Resolves #25, #26, #27 - Global block updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpitre tpitre

@kelscahill kelscahill

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #25, #26, #27 - Global block updates adventistchurch/alps-gutenberg-blocks
3 participants
@designerbrent @tpitre @kelscahill