New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.23 Media Testimonies Gutenberg block development. #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is close. I have two concerns:
Unable to Type in "Enter Quote" area
When I try to enter text in the place you have Enter Quote
, the cursor doesn't show there. Also, I can't paste text into that box.
Extra blocks that can be added
Extra blocks can be added to the carousel that are not part of the ALPS Media Testimony Block
. I tried adding a paragraph and it added but didn't look great. Can we limit what shows there to just the ALPS Media Testimony Block
?
@designerbrent Those updates are now made. Just let me know if you still have the cursor issue and what browser you are testing in. Locally it was hard for me to replicate the issue. |
@kelscahill Regarding the extra blocks, this took care of that. The the The only issue left is that the preview images are only showing at a short height for me on both Firefox and Chrome. Thanks. |
@designerbrent I believe the image issue was due to the new Wordpress version and I implemented a fix. Let me know if you have any other issues. I am still unable to replicate the quote field issue, so something on your local may need to be updated. |
@kelscahill Please fix the conflicts and then this is good to go. |
…ocks into v3.23-media-testimonies-block * 'master' of github.com:adventistchurch/alps-gutenberg-blocks: Fixing a version number error. Creating the new 1.3.7 version. feat(cta): add "Open in new window" link option # Conflicts: # dist/blocks.build.js
@designerbrent I was finally able to replicate the issue with not being able to |
Closes #23