Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.23 Media Testimonies Gutenberg block development. #24

Merged
merged 4 commits into from Apr 30, 2020

Conversation

kelscahill
Copy link
Collaborator

Closes #23

@kelscahill kelscahill changed the title #23: Media Testimonies Gutenberg block development. v3.23 Media Testimonies Gutenberg block development. Mar 30, 2020
Copy link
Collaborator

@designerbrent designerbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is close. I have two concerns:

Unable to Type in "Enter Quote" area

When I try to enter text in the place you have Enter Quote, the cursor doesn't show there. Also, I can't paste text into that box.
2020-04-10 at 3 12 PM

Extra blocks that can be added

Extra blocks can be added to the carousel that are not part of the ALPS Media Testimony Block. I tried adding a paragraph and it added but didn't look great. Can we limit what shows there to just the ALPS Media Testimony Block?

2020-04-10 at 3 15 PM

@kelscahill
Copy link
Collaborator Author

@designerbrent Those updates are now made. Just let me know if you still have the cursor issue and what browser you are testing in. Locally it was hard for me to replicate the issue.

@designerbrent
Copy link
Collaborator

@kelscahill Regarding the extra blocks, this took care of that.

The the Unable to Type in "Enter Quote" area, I'm wondering if it's my install. I had the same problem in both Firefox and Chrome on another block. I can type on both blocks, but I can't paste into it, though on some live sites, it works fine. I probably need to install a new local dev environment as it's a bit mucked up from all the testing.

The only issue left is that the preview images are only showing at a short height for me on both Firefox and Chrome.
2020-04-21 at 3 23 PM

Thanks.

@kelscahill
Copy link
Collaborator Author

kelscahill commented Apr 22, 2020

@designerbrent I believe the image issue was due to the new Wordpress version and I implemented a fix. Let me know if you have any other issues.

I am still unable to replicate the quote field issue, so something on your local may need to be updated.

@designerbrent
Copy link
Collaborator

@kelscahill Please fix the conflicts and then this is good to go.

…ocks into v3.23-media-testimonies-block

* 'master' of github.com:adventistchurch/alps-gutenberg-blocks:
  Fixing a version number error.
  Creating the new 1.3.7 version.
  feat(cta): add "Open in new window" link option

# Conflicts:
#	dist/blocks.build.js
@kelscahill
Copy link
Collaborator Author

@designerbrent I was finally able to replicate the issue with not being able to paste. Seems like the setting isSelected: false, prevents it. The merge conflict is fixed and you should be able to paste now.

@designerbrent designerbrent merged commit 33cd6b9 into master Apr 30, 2020
@designerbrent designerbrent deleted the v3.23-media-testimonies-block branch August 3, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build out Media Testimonies Gutenberg Block
2 participants