Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: in a View editor, support multiple frame selection #2124

Closed
ivan-mogilko opened this issue Sep 6, 2023 · 1 comment · Fixed by #2127
Closed

Editor: in a View editor, support multiple frame selection #2124

ivan-mogilko opened this issue Sep 6, 2023 · 1 comment · Fixed by #2127
Assignees
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor

Comments

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Sep 6, 2023

This is a repeating user request from old times until today: let select multiple frames in a View editor, which would allow to set property values for all of them at once. Usually people want to set same delay or same Flipped value for a loop, or multiple loops at once.

Properties grid already supports editing multiple objects at once, you may see how this is done for Sprites.

So the main problem here, it seems, to add multiple frame selection.

My proposal is to add classic controls, where:

  • Ctrl+Click would select another individual frame,
  • Shift+Click would select all frames between last selected one and clicked. I suppose that this should select even multiple loops: e.g. if user selected a frame 0 in loop 0, then Shift+Clicks on a frame 10 in loop 10, then all the frames in all the loops in the middle will also get selected.

UPD
About the code, the View preview pane (ViewEditor class) is constructed of multiple Loop preview panes (ViewLoopEditor class), each controlling its loop. Selection handling is shared between the Loop preview class and View pane class.

EDIT: also, there are methods in ViewLoopEditor working exclusively with "selected frame", instead of accepting a frame as a parameter. This all has to be refactored.

@ivan-mogilko ivan-mogilko added type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor context: ui/ux labels Sep 6, 2023
@ivan-mogilko
Copy link
Contributor Author

I might try doing this, from the first glance this looks like mostly a matter of reorganizing code between two ui classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant