Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: support multiframe and multiloop selection in View Editor #2127

Merged

Conversation

ivan-mogilko
Copy link
Contributor

@ivan-mogilko ivan-mogilko commented Sep 7, 2023

Resolves #2124.

This adds support for the multi-frame selection to the View editor. This includes selecting frames in different loops.
When multiple frames are selected, the Property Grid will display shared values for them, and let set values for all frames at once (this is an existing feature, previously only utilized for Sprites).

Emulates classic selection controls:

  • Click - reset selection to the given frame;
  • Ctrl + Click - add or remove selection on the given frame;
  • Shift + Click - select a range of frames, starting from the last individually selected frame and to the clicked one.

Ranged selection is supposed to work across loops too.

In terms of code, I added enum called MultiSelectAction that describes selection type, because I don't know any better. If there's an existing equivalent to this in C#, the I may replace this.

PS. I must say that the icons for delay and linked sound really helped testing this!

PPS. code tidying in AGS.Native is just because the loop drawing code was annoying, no functionality changed there.

@ivan-mogilko ivan-mogilko added type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor context: ui/ux labels Sep 7, 2023
@ivan-mogilko ivan-mogilko changed the title Editor: support multiframe and multiloop selection Editor: support multiframe and multiloop selection in View Editor Sep 7, 2023
@ivan-mogilko
Copy link
Contributor Author

Something is wrong with CI not building windows part, so here's a manually built editor for testing:
https://www.dropbox.com/scl/fi/b3h3w3oxdwhfe4cuve5xr/361-multiviewframeselect.zip?rlkey=hckjbxjfozq7fsn7nd9xzm8qg&dl=0

@PacketLauncher
Copy link

A great improvement to the View editor. Thanks! I can confirm that delaying , flipping, setting different images and setting a sound on frames in multiple loops work great! Below some feedback for other things I checked that don't currently work correctly:

  1. Upon trying to delete (Del Key) a selection of frames in multiple loops, only the frames of the first loop are getting deleted while the selected frames on different loops remain intact.

  2. The right-click context menu on any of the frames from the multiple selection removes the multiple selection and affects only the single frame clicked upon.

@ivan-mogilko
Copy link
Contributor Author

ivan-mogilko commented Sep 9, 2023

Updated, fixed selection reset on right click, made separate set of context commands depending on number of selected frames and whether they are selected in multiple loops.

https://www.dropbox.com/scl/fi/b3h3w3oxdwhfe4cuve5xr/361-multiviewframeselect.zip?rlkey=hckjbxjfozq7fsn7nd9xzm8qg&dl=0

@ivan-mogilko ivan-mogilko merged commit 4e451c4 into adventuregamestudio:master Sep 12, 2023
14 of 20 checks passed
@ivan-mogilko ivan-mogilko deleted the 361--viewmultiselect branch September 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: in a View editor, support multiple frame selection
2 participants