Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGSEditor /compile should turn alert into log messages #666

Closed
ericoporto opened this issue Mar 5, 2019 · 7 comments · Fixed by #2238
Closed

AGSEditor /compile should turn alert into log messages #666

ericoporto opened this issue Mar 5, 2019 · 7 comments · Fixed by #2238
Labels
context: game building related to compiling the game from input assets res: in consideration type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor

Comments

@ericoporto
Copy link
Member

So I am looking into building an AGS Game using a CI system.

Once you can get AGS installed in the system, it's as simple as running the following:

%AGSINSTALLDIR%\AGSEditor.exe /compile %AGSGAMEPROJECT%\Game.agf

If the game builds ok, everything is good. If when building, the game misses a plugin, even if harmless (eg: SpeechCenter), an alert window with an OK is popped up. Also if the game was made with a previous version of AGS, the ok alert window will pop up. And finally, in case of error, another window will pop up.

Ideally, when using a flag like /compile I would expect missing a plugin, or other warns to be simple log messages on console, and the build to proceed. Then if the build is ok, it should finish with 0, and if the build hit an error, finish with 1, and log the errors to console.

@ivan-mogilko ivan-mogilko added the what: editor related to the game editor label Mar 5, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

This is honestly the first time I learnt about this flag in all those years. Idk how many people know this... No wonder there was no attempt to prevent anything modal from appearing.

Hmm, this may require some good thought and maybe redesign of some processes.
For example, a warning/error reporting interface could be passed in building functions, and let external user decide what to do with alert.

PS. Only wondering for now, but can't it be a better path to build a separate "game compiler" project for this?

@morganwillcock
Copy link
Member

+1 for stand-alone game compiler

@ericoporto
Copy link
Member Author

ericoporto commented Mar 5, 2019

@ghost
Copy link

ghost commented Mar 5, 2019

Only FYI, as a hotfix we could try checking "compileAndExit" flag in GUIController.ShowMessage() methods. Maybe it's possible to dump the message to stdout instead if .NET can do that (but IIRC when running windowed app on Windows it does not write back to same terminal it was launched from).
Of course that won't cover other possible blocking events we may not know about yet.

@ericoporto
Copy link
Member Author

That hotfix works for me :]

@ericoporto
Copy link
Member Author

image

I think the hotfix proposed may be easier to implement, since there is already an option to not show popups on compile. This way, if a build fails, it will not generate the game .exe file in the compile folder and fail a possible next task of packaging in the game CI pipeline.

@ericoporto
Copy link
Member Author

Made a PR by using the hotfix as an approach. This became an issue to me because I wanted to test a 3.6.1 game in the command line and the Beta warning pop-up was hanging my pipeline.

Decouple game build tools from the Editor automation moved this from To do to Done Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: game building related to compiling the game from input assets res: in consideration type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Development

Successfully merging a pull request may close this issue.

3 participants