Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor plugins write to Game.agf even when not used in the project #677

Open
ghost opened this issue Mar 19, 2019 · 2 comments
Open

Editor plugins write to Game.agf even when not used in the project #677

ghost opened this issue Mar 19, 2019 · 2 comments
Labels
context: editor assets related to input files for editing the game type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor

Comments

@ghost
Copy link

ghost commented Mar 19, 2019

Unlike the engine plugins that has to be explicitly enabled for the game, editor plugins seem to hook up to any game on their own and write their data into game project even if you don't use them.

Easiest way to reproduce:

  • download SpeechCenter plugin and install in the AGS editor folder;
  • open any game in the editor and save.
  • inspect Game.agf, you will notice there's section now:
< Component Name="SpeechCenter"' >
  • if you remove the plugin and open same project you will be warned about missing plugin and that the game may loose data if you save now.

Not sure if this is a bug or larger design oversight. I think there should be some mechanism similar to engine plugins that would add/remove plugin component in game project source.

@ivan-mogilko ivan-mogilko added the what: editor related to the game editor label Mar 19, 2019
@ivan-mogilko ivan-mogilko added context: editor assets related to input files for editing the game type: enhancement a suggestion or necessity to have something improved labels Sep 29, 2019
@ericoporto
Copy link
Member

I wish there was a way to not have the pop up show with the ok button because it appears even if the Editor is called with /compile flag, hanging a CI pipeline.

@ghost
Copy link
Author

ghost commented Dec 22, 2019

I wish there was a way to not have the pop up show with the ok button because it appears even if the Editor is called with /compile flag, hanging a CI pipeline.

I believe there was a relevant ticket for this: #666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: editor assets related to input files for editing the game type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Projects
None yet
Development

No branches or pull requests

2 participants