Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten some fixes #1932

Merged
merged 4 commits into from Feb 26, 2023
Merged

Emscripten some fixes #1932

merged 4 commits into from Feb 26, 2023

Conversation

ericoporto
Copy link
Member

@ericoporto ericoporto commented Feb 25, 2023 •
edited

  • fix reported bug where the cog wheel ⚙️ button disappeared under certain conditions
  • fix to make sure focus is set on the canvas when clicking it, even in an iframe (SDL has a prevent default that blocked this defaul behavior on browser)
  • lower the font size a bit
  • fix bug where iframe size is not set correctly when returning from fullscreen, there are some hacks there but I tried to make them minimal and non-brittle, we can perhaps rollback on a lot of it once this is fixed upstream

pushed these changes:

https://ericoporto.github.io/agsjs/
https://eri0o.itch.io/agsjs-test (p: agstest)

@ivan-mogilko ivan-mogilko merged commit 3e4db1a into adventuregamestudio:master Feb 26, 2023
@ericoporto ericoporto deleted the emscripten-some-fixes branch February 26, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericoporto @ivan-mogilko