Editor: no need to use shell in our started process #2391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think everywhere we start a new process from the Editor the process doesn't need a shell, as we aren't using commands from those, so it should be alright to set
UseShellExecute
to false in all of them.I have a guess that this would not cause the Defender to trigger in this specific case reported in the forums : https://www.adventuregamestudio.co.uk/forums/beginners-technical-questions/ags-3-6-0-crashing-when-i-hit-f5-to-launch-the-game/msg636662661/#msg636662661