Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler int fixes #273

Merged
merged 10 commits into from Sep 16, 2015
Merged

Compiler int fixes #273

merged 10 commits into from Sep 16, 2015

Conversation

sonneveld
Copy link
Member

  • parse integers with overflow checks
  • allow default parameters up to INT_MIN/INT_MAX
  • support negative enums

@sonneveld
Copy link
Member Author

Marked as wip so I can fix some error messages after the symbol-fixes merge goes in.

@ghost
Copy link

ghost commented Sep 11, 2015

One thing I noticed is that if I type a negative constant bigger than an 'int' can handle, then error message referes to positive constant instead (or maybe absolute value of one).
Do you think it matters?

@sonneveld
Copy link
Member Author

I think it does.. otherwise someone will ask why the overflow. Will fix that.

ivan-mogilko added a commit that referenced this pull request Sep 16, 2015
@ivan-mogilko
Merge pull request #273 from sonneveld/compiler-int-fixes
6912fc5 
Compiler int fixes
@ivan-mogilko ivan-mogilko merged commit 6912fc5 into adventuregamestudio:develop-3.3.5 Sep 16, 2015
@sonneveld sonneveld deleted the compiler-int-fixes branch October 14, 2015 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sonneveld @ivan-mogilko