Skip to content

insert_slice_clone can double drop if Clone panics.

Moderate severity GitHub Reviewed Published May 24, 2022 to the GitHub Advisory Database • Updated Jun 13, 2023

Package

cargo qwutils (Rust)

Affected versions

< 0.3.1

Patched versions

0.3.1

Description

Affected versions of this crate used ptr::copy when inserting into the middle of a Vec. When ownership was temporarily duplicated during this copy, it calls the clone method of a user provided element.

This issue can result in an element being double-freed if the clone call panics.

Commit 20cb73d fixed this issue by adding a set_len(0) call before operating on the vector to avoid dropping the elements during a panic.

References

Published by the National Vulnerability Database Feb 9, 2021
Published to the GitHub Advisory Database May 24, 2022
Reviewed Jun 17, 2022
Last updated Jun 13, 2023

Severity

Moderate
5.3
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
Low
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L

Weaknesses

CVE ID

CVE-2021-26954

GHSA ID

GHSA-68p4-pjpf-xwcq
Checking history
See something to contribute? Suggest improvements for this vulnerability.