Skip to content

Heap OOB in `ResourceScatterUpdate`

High severity GitHub Reviewed Published Aug 11, 2021 in tensorflow/tensorflow • Updated Feb 1, 2023

Package

pip tensorflow (pip)

Affected versions

< 2.3.4
>= 2.4.0, < 2.4.3
= 2.5.0

Patched versions

2.3.4
2.4.3
2.5.1
pip tensorflow-cpu (pip)
< 2.3.4
>= 2.4.0, < 2.4.3
= 2.5.0
2.3.4
2.4.3
2.5.1
pip tensorflow-gpu (pip)
< 2.3.4
>= 2.4.0, < 2.4.3
= 2.5.0
2.3.4
2.4.3
2.5.1

Description

Impact

An attacker can trigger a read from outside of bounds of heap allocated data by sending invalid arguments to tf.raw_ops.ResourceScatterUpdate:

import tensorflow as tf

v = tf.Variable([b'vvv'])
tf.raw_ops.ResourceScatterUpdate(
  resource=v.handle,
  indices=[0],
  updates=['1', '2', '3', '4', '5'])

The implementation has an incomplete validation of the relationship between the shapes of indices and updates: instead of checking that the shape of indices is a prefix of the shape of updates (so that broadcasting can happen), code only checks that the number of elements in these two tensors are in a divisibility relationship.

Patches

We have patched the issue in GitHub commit 01cff3f986259d661103412a20745928c727326f.

The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, TensorFlow 2.4.3, and TensorFlow 2.3.4, as these are also affected and still in supported range.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution

This vulnerability has been reported by members of the Aivul Team from Qihoo 360.

References

@mihaimaruseac mihaimaruseac published to tensorflow/tensorflow Aug 11, 2021
Published by the National Vulnerability Database Aug 12, 2021
Reviewed Aug 24, 2021
Published to the GitHub Advisory Database Aug 25, 2021
Last updated Feb 1, 2023

Severity

High
7.3
/ 10

CVSS base metrics

Attack vector
Local
Attack complexity
Low
Privileges required
Low
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
Low
Availability
High
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:H/I:L/A:H

Weaknesses

CVE ID

CVE-2021-37655

GHSA ID

GHSA-7fvx-3jfc-2cpc

Source code

No known source code
Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.