Skip to content

Improper Restriction of XML External Entity Reference in DiffPlug Spotless

High severity GitHub Reviewed Published Jul 5, 2019 to the GitHub Advisory Database • Updated Jan 28, 2023

Package

maven com.diffplug.spotless:spotless-maven-plugin (Maven)

Affected versions

< 1.20.0

Patched versions

1.20.0
maven com.diffplug.spotless:spotless-plugin-gradle (Maven)
< 3.20.0
3.20.0

Description

In DiffPlug Spotless before 1.20.0 (library and Maven plugin) and before 3.20.0 (Gradle plugin), the XML parser would resolve external entities over both HTTP and HTTPS and didn't respect the resolveExternalEntities setting. For example, this allows disclosure of file contents to a MITM attacker if a victim performs a spotlessApply operation on an untrusted XML file.

References

Published by the National Vulnerability Database Jun 28, 2019
Reviewed Jul 1, 2019
Published to the GitHub Advisory Database Jul 5, 2019
Last updated Jan 28, 2023

Severity

High
7.5
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
High
Privileges required
None
User interaction
Required
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
High
CVSS:3.0/AV:N/AC:H/PR:N/UI:R/S:U/C:H/I:H/A:H

Weaknesses

CVE ID

CVE-2019-9843

GHSA ID

GHSA-7v35-qwwj-p98g

Source code

Checking history
See something to contribute? Suggest improvements for this vulnerability.