Skip to content

DDFFileParser is vulnerable to XXE Attacks

Moderate severity GitHub Reviewed Published Aug 31, 2023 in eclipse-leshan/leshan • Updated Nov 8, 2023

Package

maven org.eclipse.leshan:leshan-core (Maven)

Affected versions

< 1.5.0
>= 2.0.0-M1, < 2.0.0-M13

Patched versions

1.5.0
2.0.0-M13

Description

Impact

DDFFileParser and DefaultDDFFileValidator (and so ObjectLoader) are vulnerable to XXE Attacks.

DDF file is a LWM2M format used to store LWM2M object description.
Leshan users are impacted only if they parse untrusted DDF files (e.g. if they let external users provide their own model), in that case they MUST upgrade to fixed version.
If you parse only trusted DDF file and validate only with trusted xml schema, upgrading is not mandatory.

Patches

This is fixed in v1.5.0 and 2.0.0-M13.

Workarounds

No easy way. Eventually writing your own DDFFileParser/DefaultDDFFileValidator (and so ObjectLoader) creating a DocumentBuilderFactory with :

// For DDFFileParser
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
factory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true); // Disable DTDs
factory.setXIncludeAware(false); // Disable XML Inclusions
factory.setExpandEntityReferences(false); // disable expand entity reference nodes

// For DefaultDDFFileValidator
SchemaFactory factory = SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
factory.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, "");
factory.setProperty(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");

References

References

@sbernard31 sbernard31 published to eclipse-leshan/leshan Aug 31, 2023
Published by the National Vulnerability Database Aug 31, 2023
Published to the GitHub Advisory Database Aug 31, 2023
Reviewed Aug 31, 2023
Last updated Nov 8, 2023

Severity

Moderate
6.5
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
High
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
Low
Availability
None
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:L/A:N

Weaknesses

CVE ID

CVE-2023-41034

GHSA ID

GHSA-wc9j-gc65-3cm7

Source code

Credits

Checking history
See something to contribute? Suggest improvements for this vulnerability.