Skip to content

Double free in toodee

Critical severity GitHub Reviewed Published Sep 1, 2021 to the GitHub Advisory Database • Updated Jun 13, 2023

Package

cargo toodee (Rust)

Affected versions

< 0.3.0

Patched versions

0.3.0

Description

When inserting rows from an iterator at a particular index, toodee would shift items over, duplicating their ownership. The space reserved for the new elements was based on the len() returned by the ExactSizeIterator.

This could result in elements in the array being freed twice if the iterator panics. Uninitialized or previously freed elements could also be exposed if the len() didn't match the number of elements.

These issues were fixed in commit ced70c17 by temporarily setting the length of the array smaller while processing it and adding assertions on the number of elements returned by the iterator.

References

Published by the National Vulnerability Database Mar 5, 2021
Reviewed Aug 30, 2021
Published to the GitHub Advisory Database Sep 1, 2021
Last updated Jun 13, 2023

Severity

Critical
9.8
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
High
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H

Weaknesses

CVE ID

CVE-2021-28028

GHSA ID

GHSA-wcvp-r8j8-47pc

Source code

Checking history
See something to contribute? Suggest improvements for this vulnerability.