OpenZeppelin Contracts's GovernorVotesQuorumFraction updates to quorum may affect past defeated proposals
High severity
GitHub Reviewed
Published
Jul 28, 2022
in
OpenZeppelin/openzeppelin-contracts
•
Updated Jan 30, 2023
Description
Published by the National Vulnerability Database
Aug 1, 2022
Published to the GitHub Advisory Database
Aug 18, 2022
Reviewed
Aug 18, 2022
Last updated
Jan 30, 2023
Impact
This issue concerns instances of Governor that use the module
GovernorVotesQuorumFraction, a mechanism that determines quorum requirements as a percentage of the voting token's total supply. In affected instances, when a proposal is passed to lower the quorum requirement, past proposals may become executable if they had been defeated only due to lack of quorum, and the number of votes it received meets the new quorum requirement.Analysis of instances on chain found only one proposal that met this condition, and we are actively monitoring for new occurrences of this particular issue.
Patches
This issue has been patched in v4.7.2.
Workarounds
Avoid lowering quorum requirements if a past proposal was defeated for lack of quorum.
References
OpenZeppelin/openzeppelin-contracts#3561
For more information
If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at security@openzeppelin.com.
References