Fix issue where user key saved to key of same value #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user key was being saved to a key that was the text of the user key instead of adzUserKey. This caused the user key to essentially be lost every time, a new key being generated, and then saved to a completely different key in the keychain. Everything pulled out of adzUserKey would always be nil.
|
@tyten Thanks for the PR! I think it will do the trick. We hope to be able to merge it and deploy a new version of the iOS SDK to CocoaPods very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user key was being saved to a key that was the text of the user key
instead of adzUserKey. This caused the user key to essentially be lost
every time, a new key being generated, and then saved to a completely
different key in the keychain. Everything pulled out of adzUserKey
would always be nil.