Fix omit func in core-utils.ts #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks. Package with hotfix released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A further fix of #124 , sorry for a bad JS to TS manual-translation.
I previously did a hot fix in the JS file in my node_modules/react-spaces and created the PR with a manual-translation from JS to TS, causing a misspell that
for...in(should befor...of), and now the<Custom>component is full broken in prop-type validation. This PR is going to fix it.Going through your code and found that you prefer the
forEachtofor...of, this PR is also made base onforEach. I tested it with transpile to JS again in typescript playground and didn't find another break yet.