Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the add link button for specific URL protocols #28

Closed
aecreations opened this issue Aug 27, 2022 · 1 comment
Closed

Disable the add link button for specific URL protocols #28

aecreations opened this issue Aug 27, 2022 · 1 comment
Assignees
@aecreations
Labels
fixed
Milestone
0.9 Makai

Comments

@aecreations
Copy link
Owner

The "Add Current Tab" button in the reading list sidebar should be disabled at all times if the URL doesn't start with "http://" or "https://".

This ensures that "about" pages, extension pages cannot be added to the reading list. However, pages that are being displayed in Reader View should be allowed to be added.
@aecreations aecreations added this to the 0.9 Makai milestone Aug 27, 2022
@aecreations aecreations self-assigned this Aug 27, 2022
@aecreations
Copy link
Owner Author

Pages displayed in Reader Mode have a URL with prefix "about:reader".

aecreations added a commit that referenced this issue Sep 23, 2022
@aecreations
Disable the Add Link button for unsupported protocols (issue #28)
12c1dcb 
- Only allow http, https and about:reader
aecreations added a commit that referenced this issue Sep 28, 2022
@aecreations
Disable the Add Link button for unsupported protocols (issue #28)
8d9ae44 
- Backported to 0.8.4
aecreations added a commit that referenced this issue Sep 28, 2022
@aecreations
Disable the Add Link button for unsupported protocols (issue #28)
8bd29e3 
- Also handle the add link CTA button in the sidebar empty state UI
aecreations added a commit that referenced this issue Sep 28, 2022
@aecreations
Disable the Add Link button for unsupported protocols (issue #28)
55471dc 
- Also handle the add link CTA button in the sidebar empty state UI (ported from 0.8.4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aecreations aecreations

Labels
fixed
Projects
None yet
Milestone
0.9 Makai
Development

No branches or pull requests
1 participant
@aecreations