Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding unsupported links from the web page context menu #40

Closed
aecreations opened this issue Sep 23, 2022 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@aecreations
Copy link
Owner

The context menu item appears even on system pages (e.g. "about:debugging"). There doesn't seem to be a way to control visibility of an extension's context menu items for specific URL protocols.

Prevent the user from adding unsupported URLs to the reading list by checking the URL that is being added from the page context menu. If the page shouldn't be added to the reading list, show a notification with an error message, e.g.: "This page can't be added to Read Next."

@aecreations aecreations added this to the 0.9 Makai milestone Sep 23, 2022
@aecreations aecreations self-assigned this Sep 23, 2022
@aecreations aecreations added bug Something isn't working and removed bug Something isn't working labels Sep 23, 2022
aecreations added a commit that referenced this issue Sep 28, 2022
(issue #40)
- Partial backport to 0.8.4 (browser console logging only, no notification)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant