Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use flavor for host, scheme and logo #195

Merged
merged 15 commits into from
Mar 15, 2024

Conversation

armanddidierjean
Copy link
Member

No description provided.

@armanddidierjean armanddidierjean added the core This PR change the core label Nov 7, 2023
@armanddidierjean armanddidierjean marked this pull request as draft November 7, 2023 16:55
@armanddidierjean armanddidierjean changed the base branch from main to refactoring November 7, 2023 16:55
@maximeroucher maximeroucher linked an issue Nov 15, 2023 that may be closed by this pull request
3 tasks
Base automatically changed from refactoring to main November 16, 2023 15:28
.vscode/launch.json Outdated Show resolved Hide resolved
@julien4215 julien4215 force-pushed the feat/flavor-for-scheme-host-and-image branch from d59a02f to 3b44781 Compare February 17, 2024 14:51
@julien4215 julien4215 dismissed their stale review February 17, 2024 14:52

To not approve my own changes

@julien4215 julien4215 force-pushed the feat/flavor-for-scheme-host-and-image branch from b3b575e to cf1099a Compare February 17, 2024 17:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.98%. Comparing base (4402471) to head (a68bd43).

Files Patch % Lines
lib/tools/functions.dart 45.45% 6 Missing ⚠️
...cinema/repositories/session_poster_repository.dart 0.00% 1 Missing ⚠️
...b/vote/repositories/contender_logo_repository.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   56.04%   55.98%   -0.07%     
==========================================
  Files         160      160              
  Lines        3508     3519      +11     
==========================================
+ Hits         1966     1970       +4     
- Misses       1542     1549       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 marked this pull request as ready for review February 17, 2024 17:24
@julien4215 julien4215 force-pushed the feat/flavor-for-scheme-host-and-image branch 2 times, most recently from 94d4d37 to 0b6c75c Compare February 23, 2024 13:01
.env.template Show resolved Hide resolved
@guillaumetavernier guillaumetavernier added ready for review This PR is ready to be reviewed waiting backend and removed waiting backend labels Feb 25, 2024
@guillaumetavernier guillaumetavernier added ready for review This PR is ready to be reviewed and removed ready for review This PR is ready to be reviewed labels Mar 3, 2024
@Petitoto
Copy link
Member

Petitoto commented Mar 5, 2024

On Android, redirect scheme does not work after login. This should be updated to match the flavor:

manifestPlaceholders += [
'appAuthRedirectScheme': 'fr.myecl.titan'
]

@julien4215 julien4215 force-pushed the feat/flavor-for-scheme-host-and-image branch from a68bd43 to d31ede5 Compare March 14, 2024 13:02
@julien4215
Copy link
Collaborator

On Android, redirect scheme does not work after login. This should be updated to match the flavor:

manifestPlaceholders += [
'appAuthRedirectScheme': 'fr.myecl.titan'
]

It should now be fixed

@julien4215 julien4215 requested review from maximeroucher and Petitoto and removed request for Petitoto and maximeroucher March 14, 2024 14:44
@Petitoto
Copy link
Member

Petitoto commented Mar 15, 2024

This needs to be tested on iOS before beeing merged @armanddidierjean

@armanddidierjean armanddidierjean merged commit a7eae43 into main Mar 15, 2024
5 checks passed
@armanddidierjean armanddidierjean deleted the feat/flavor-for-scheme-host-and-image branch March 15, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This PR change the core ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flavor issues tracker
5 participants